Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixes Android pubspec #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Copy link
Contributor

@JeroenWeener JeroenWeener commented Mar 13, 2023

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Adds the dartPluginClass declaration to the pubspec.

πŸ’₯ Does this PR introduce a breaking change?

No.

πŸ“ Links to relevant issues/docs

This PR is part of the journey to transitioning to the federated plugin architecture. See #33.

πŸ€” Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to make the version number represent a hotfix.

@@ -1,3 +1,7 @@
## 1.0.1
Copy link
Member

@mvanbeusekom mvanbeusekom Mar 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be considered a hotfix. In this case I would update the version to:

Suggested change
## 1.0.1
## 1.0.0+1

@@ -3,7 +3,7 @@ description: An Android implementation for the google_api_availability plugin.
repository: https://github.com/baseflow/flutter-google-api-availability/tree/main/google_api_availability_android
# NOTE: We strongly prefer non-breaking changes, even at the expense of a
# less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes
version: 1.0.0
version: 1.0.1
Copy link
Member

@mvanbeusekom mvanbeusekom Mar 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hotfix version bump:

Suggested change
version: 1.0.1
version: 1.0.0+1

...com:jeroenweener/flutter-google-api-availability into enhancement/finalize-federated-architecture
Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvanbeusekom mvanbeusekom merged commit 92cd5c6 into Baseflow:main Mar 14, 2023
Copy link

paulppn commented Mar 14, 2023

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

@paulppn paulppn Awaiting requested review from paulppn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle γ«γ‚ˆγ£γ¦ε€‰ζ›γ•γ‚ŒγŸγƒšγƒΌγ‚Έ (->γ‚ͺγƒͺγ‚ΈγƒŠγƒ«) /