Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Extract Android implementation to separate folder #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvanbeusekom merged 23 commits into Baseflow:main from JeroenWeener:enhancement/platform-android
Mar 13, 2023

Conversation

Copy link
Contributor

@JeroenWeener JeroenWeener commented Mar 10, 2023

Note: the reference to google_api_platform_interface in google_api_platform_interface_android/pubspec.yaml is not resolving because google_api_platform_interface has not yet been published to pub.dev.

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

The Android implementation has been extracted to a plugin implementation, following the federated plugin architecture.
The 'old' Android code is still there, and remains in use. Once the federated structure is in place we can remove the 'old' Android code and switch over to the new code.

💥 Does this PR introduce a breaking change?

No.

🐛 Recommendations for testing

Dart tests for the Android platform have been updated.

📝 Links to relevant issues/docs

This PR is part of #33.

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeroenWeener and others added 17 commits March 13, 2023 10:22 
...ement/platform-interface"
This reverts commit 101bf12, reversing
changes made to d828355.
...r/flutter-google-api-availability into enhancement/platform-android
Copy link

codecov bot commented Mar 13, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -1.09 ⚠️

Comparison is base (9be7479) 93.93% compared to head (bcc4256) 92.85%.

Additional details and impacted files 
@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 93.93% 92.85% -1.09% 
==========================================
 Files 2 1 -1 
 Lines 33 28 -5 
==========================================
- Hits 31 26 -5 
 Misses 2 2
Impacted Files Coverage Δ
..._availability/lib/src/google_api_availability.dart 92.85% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mvanbeusekom mvanbeusekom merged commit c4685dc into Baseflow:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /