-
-
Notifications
You must be signed in to change notification settings - Fork 35
Move app-facing code to separate folder #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mvanbeusekom
merged 1 commit into
Baseflow:main
from
JeroenWeener:enhancement/move-app-facing-code
Mar 9, 2023
Merged
Move app-facing code to separate folder #36
mvanbeusekom
merged 1 commit into
Baseflow:main
from
JeroenWeener:enhancement/move-app-facing-code
Mar 9, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvanbeusekom
mvanbeusekom
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
This PR moves all plugin related code, including pubspec.yaml and such, to a separate folder
google_api_availability. This folder will contain all app-facing code. In future PRs, code will be stripped from this folder and put in separate folders. For example, Android specific code will be moved togoogle_api_availability_android, which will contain the plugin platform implementation code for Android.Currently, the code base is not separated according to the federated plugin architecture.
🆕 What is the new behavior (if this is a feature change)?
All app-facing code (which for now is everything) will be moved to the subfolder
google_api_availability.💥 Does this PR introduce a breaking change?
No.
🐛 Recommendations for testing
Since code has only be moved, tests should still produce the same results as before.
📝 Links to relevant issues/docs
This PR is part of #33.
🤔 Checklist before submitting