-
-
Notifications
You must be signed in to change notification settings - Fork 35
Updated plugin and made small improvements and changes #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@JDDV, I think you can fix the analyser error by adding the flutter_lints: ^1.0.4 dependency to the pubspec.yaml file inside the example folder.
@JDDV, I think you can fix the analyser error by adding the
flutter_lints: ^1.0.4dependency to thepubspec.yamlfile inside theexamplefolder.
I did that first as a fix, but I changed it to adding these lines in the option_analysis.yaml:
# workaround for https://github.com/dart-lang/sdk/issues/42910
- 'example/**'
since that how it initialy was, should I change it back?
I did that first as a fix, but I changed it to adding these lines in the option_analysis.yaml:
# workaround for https://github.com/dart-lang/sdk/issues/42910 - 'example/**'since that how it initialy was, should I change it back?
Yes I think you should only add the dependency to the example/pubspec.yaml file but do not add a separate analysis_options.yaml file (I noticed you added this file as well in your first attempt to fix the error).
And make sure to remove the - 'example/**' line from the root analysis_options.yaml file.
I did that first as a fix, but I changed it to adding these lines in the option_analysis.yaml:
# workaround for https://github.com/dart-lang/sdk/issues/42910 - 'example/**'since that how it initialy was, should I change it back?
Yes I think you should only add the dependency to the
example/pubspec.yamlfile but do not add a separateanalysis_options.yamlfile (I noticed you added this file as well in your first attempt to fix the error).And make sure to remove the
- 'example/**'line from the rootanalysis_options.yamlfile.
Done
Codecov Report
@@ Coverage Diff @@ ## master #27 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 2 2 Lines 13 12 -1 ========================================= - Hits 13 12 -1
Continue to review full report at Codecov.
|
Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>
Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>
Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>
Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
pubspec.yamlto newer versions ofSDKandflutterand addingflutter_lintsas a dependency;analysis_options.yamlfor usingflutter_lints;compileSdkVersionandtargetSdkVersionin thebuild.gradleAndroidManifest🆕 What is the new behavior (if this is a feature change)?
💥 Does this PR introduce a breaking change?
No
🐛 Recommendations for testing
📝 Links to relevant issues/docs
🤔 Checklist before submitting