-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Comments
feat add processing conversation on desktop#4607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a widget to display conversations that are currently being processed on the desktop version of the application. The implementation is clean and integrates well with the existing conversation list. I have one suggestion to improve the new widget by making it display dynamic data instead of being a static placeholder, which also resolves an unused parameter issue.
app/lib/desktop/pages/conversations/widgets/desktop_processing_conversation_widget.dart
Outdated
Show resolved
Hide resolved
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
beastoin
commented
Feb 17, 2026
Hey @krushnarout, sorry about the delay on this — @beastoin doesn't have bandwidth to review it right now and doesn't have any plans to in the near future.
@aaravgarg, could you take a look and make the call on this one? Feel free to approve and merge if it looks good to you. Thanks both!
Hey @krushnarout 👋
Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request.
After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:
- Project standards — Ensuring consistency across the codebase
- User needs — Making sure changes align with what our users need
- Code best practices — Maintaining code quality and maintainability
- Project direction — Keeping aligned with our roadmap and vision
Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out.
Thank you for being part of the Omi community! 💜
Uh oh!
There was an error while loading. Please reload this page.