-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
📝 WalkthroughWalkthroughA new PR Title Convention section is added to AGENTS.md, providing structured guidance on formatting pull request titles with team/module and type labels, including practical examples for reference. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@AGENTS.md`:
- Around line 685-687: The two fenced code blocks in AGENTS.md (the template
block containing "[team/module][type] Subject" and the list block with PR
examples like "[campus][feature] Add bus schedule notification") are missing
language identifiers and trigger markdownlint MD040; update each opening
triple-backtick to include a language tag (e.g., use "text") so they become
```text, ensuring both the single-line template block and the multi-line example
block (also the similar block around lines 715-722) are modified accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add language identifiers to fenced code blocks to satisfy markdownlint.
Both new fenced blocks omit a language tag (MD040), which will keep lint warnings active.
🔧 Proposed fix
-``` +```text [team/module][type] Subject
@@
- +text
[campus][feature] Add bus schedule notification
[campus][fix] Resolve crash on dining menu screen
[user][refactor] Extract common auth validation logic
[business][enhancement] Improve store detail loading performance
[koin project][chore] Update Gradle dependencies to latest versions
[koin project][documentation] Add PR title convention to AGENTS.md
Also applies to: 715-722
🧰 Tools
🪛 markdownlint-cli2 (0.21.0)
[warning] 685-685: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@AGENTS.md` around lines 685 - 687, The two fenced code blocks in AGENTS.md
(the template block containing "[team/module][type] Subject" and the list block
with PR examples like "[campus][feature] Add bus schedule notification") are
missing language identifiers and trigger markdownlint MD040; update each opening
triple-backtick to include a language tag (e.g., use "text") so they become
```text, ensuring both the single-line template block and the multi-line example
block (also the similar block around lines 715-722) are modified accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
근데 이 라벨 이제 없애도 되지 않을까요 @KYM-P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enhancement는 없습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이것도 그냥 docs에요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
대문자로 시작해요
@KYM-P
KYM-P
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
팀 라벨이 사라졌어요 수정해주세용
Uh oh!
There was an error while loading. Please reload this page.
PR 개요
이슈 번호: #1301
PR 체크리스트
작업사항
작업사항의 상세한 설명
AGENTS.md에 PR 컨벤션을 추가하였습니다
논의 사항
스크린샷
추가내용
Summary by CodeRabbit