-
Notifications
You must be signed in to change notification settings - Fork 670
Adding missing XML Namespace support to XmlApplier#145
Open
pmooij wants to merge 1 commit intoAzure:master from
Open
Adding missing XML Namespace support to XmlApplier #145pmooij wants to merge 1 commit intoAzure:master from
pmooij wants to merge 1 commit intoAzure:master from
Conversation
(exactly the same way as it is implemented on XmlDomExtractor)
CLA assistant check
All CLA requirements met.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XmlApplier was missing Namespace support.
Namespace support for XmlApplier is crucial for for using XPath expressions targeting the non-default namespace.
for this pull request I copied the existing XmlDomExtractor implementation for Namespaces and added this to XmlDomExtractor as well.