-
Notifications
You must be signed in to change notification settings - Fork 666
Comments
[DRAFT] [BREAKING] FEAT Refactor Harm Category as StrEnum#998
Open
eugeniavkim wants to merge 12 commits intoAzure:main from
Open
[DRAFT] [BREAKING] FEAT Refactor Harm Category as StrEnum #998eugeniavkim wants to merge 12 commits intoAzure:main from
eugeniavkim wants to merge 12 commits intoAzure:main from
Conversation
@eugeniavkim
eugeniavkim
changed the title
(削除) [DRAFT] [BREAKING] FEAT Refactor Harm Category as an enum (削除ここまで)
(追記) [DRAFT] [BREAKING] FEAT Refactor Harm Category as StrEnum (追記ここまで)
Jul 3, 2025
pyrit/models/harm_category.py
Outdated
"bias": cls.REPRESENTATIONAL,
"sexism": cls.REPRESENTATIONAL,
"racism": cls.REPRESENTATIONAL,
"homophobia": cls.REPRESENTATIONAL,
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If multiple map to the same one then it's possible that a list of categories maps to a list with duplicates. We should eliminate the duplicates and have a test case for that. It could otherwise result in double counting depending on how downstream code consumes these.
SeedPrompt(
value=prompt_text,
data_type="text",
name="XSTest Examples",
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove name or empty string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
In order to make
harm_categorieseasier to search through and group by some alias names, this PR refactors our previousStringharm categories into a classHarmCategorywith categories that are not included in the list to be recognized in anOTHERcategory. This also does not include all harm categories, but others can continue to add harm areas that they would like to probe for and score with.This PR is a breaking change as it does affect all datasets,
SeedPromptinitialization, and tests.The following items must be complete before changing from DRAFT Status:
HarmCategory