-
Notifications
You must be signed in to change notification settings - Fork 117
tools-image: Clear /tmp contents as last step - #441
Open
Jeremi Piotrowski (jepio) wants to merge 1 commit into
Open
tools-image: Clear /tmp contents as last step #441Jeremi Piotrowski (jepio) wants to merge 1 commit into
Jeremi Piotrowski (jepio) wants to merge 1 commit into
Conversation
/tmp in cloudshell has a whole bunch of leftover directories and files from the various installation steps that run during the build. Clear /tmp/ as the final step before finalizing the image. This doesn't make the image smaller because the files are still present in previous layers but makes the user experience better. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
# Remove su so users don't have su access by default.
RUN rm -f ./linux/Dockerfile && rm -f /bin/su
# cleanup tmp files left behind by installation
RUN find /tmp/ -mindepth 1 -delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if we can clean up such stuff as soon as it is created in any RUN step? So there is no cruft in any layer.
As in this is a nice addition from security POV, but not from the size POV.
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would love to, but the files seem to come many differents RUN steps, and it would make the dockerfile quite hard to read. Although i will check - maybe it's only a small number of RUN that need the cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/tmp in cloudshell has a whole bunch of leftover directories and files from the various installation steps that run during the build. Clear /tmp/ as the final step before finalizing the image. This doesn't make the image smaller because the files are still present in previous layers but makes the user experience better.