Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add Playwright Tests #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pamelafox merged 17 commits into Azure-Samples:main from john0isaac:add-playwright-tests
Aug 1, 2024
Merged

Conversation

Copy link
Contributor

@john0isaac john0isaac commented Jul 24, 2024
edited
Loading

Purpose

This PR adds playwright tests.

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[x] No

Type of change

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff manually on my code.

Copy link
Contributor

I'm just running the CI on Windows myself to see for myself/ get a link for reporting.

john0isaac reacted with thumbs up emoji

Copy link
Contributor

john0isaac reacted with heart emoji

Copy link
Contributor

Only running on Mac now, merging. Thanks so much!

john0isaac reacted with heart emoji

@pamelafox pamelafox merged commit 964ee33 into Azure-Samples:main Aug 1, 2024
13 checks passed
@john0isaac john0isaac deleted the add-playwright-tests branch August 1, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamelafox pamelafox pamelafox left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /