Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Port to azd env get value #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pamelafox merged 9 commits into main from azdenvgetval
Aug 9, 2024
Merged

Port to azd env get value #58

pamelafox merged 9 commits into main from azdenvgetval
Aug 9, 2024

Conversation

Copy link
Contributor

@pamelafox pamelafox commented Jul 9, 2024

Purpose

This ports to azd env get-value, which will be in a future azd release.
Azure/azure-dev#4080

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[X] No

Type of change

[ ] Bugfix
[ ] Feature
[X] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff manually on my code.

@pamelafox pamelafox marked this pull request as ready for review August 9, 2024 20:45
Copy link
Contributor

john0isaac commented Aug 9, 2024
edited
Loading

@pamelafox before you merge remove echo=True from the engine creation
The logs are full of sqlalchmey logs

Copy link
Contributor Author

Lol I kind of love those logs, its like the Matrix, but good point, I think I accidentally turned that to True in a recent branch. Turning to False.

john0isaac reacted with laugh emoji

@pamelafox pamelafox merged commit 2acf1fd into main Aug 9, 2024
13 checks passed
@pamelafox pamelafox deleted the azdenvgetval branch August 9, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weikanglim weikanglim weikanglim left review comments

+1 more reviewer

@john0isaac john0isaac john0isaac requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /