Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Restructure files #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pamelafox merged 3 commits into Azure-Samples:main from john0isaac:restructure-files
Jul 22, 2024
Merged

Conversation

Copy link
Contributor

@john0isaac john0isaac commented Jun 29, 2024

Purpose

Fix #52

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[x] No

Type of change

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • [-] The current tests all pass (python -m pytest).
  • [-] I added tests that prove my fix is effective or that my feature works
  • [-] I ran python -m pytest --cov to verify 100% coverage of added lines
  • [-] I ran python -m mypy to check for type errors
  • [-] I either used the pre-commit hooks or ran ruff manually on my code.

Copy link
Contributor

mypy is unhappy (as usual). I'm placating it.

Copy link
Contributor Author

What's weird is that these tests passed last Thursday.
I upgraded my local mypy version and got the same errors. I think it's the latest release.
Thanks! For fixing it.

Copy link
Contributor

@john0isaac Yep latest mypy came out last week, and caused a bunch of issues all over. It broke azure-search-openai-demo CI cuz of python/mypy#17550 which I've also just fixed.

john0isaac reacted with thumbs up emoji

@pamelafox pamelafox merged commit 4864a39 into Azure-Samples:main Jul 22, 2024
@john0isaac john0isaac deleted the restructure-files branch July 22, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamelafox pamelafox pamelafox left review comments

+1 more reviewer

@Bonniemarie216 Bonniemarie216 Bonniemarie216 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused code from container

AltStyle によって変換されたページ (->オリジナル) /