forked from torvalds/linux
-
Notifications
You must be signed in to change notification settings - Fork 199
arm64: dts: apple: t8103: Add SIO alias - #602
Merged
Merged
Conversation
m1n1 looks up the SIO node through the 'sio' FDT alias when setting up SIO firmware data. T8103 device trees lack this alias, causing m1n1 to silently skip SIO setup and leave the node disabled. Add the alias to the common T8103 device tree, matching the T600x device trees. Tested on a J313 MacBook Air (M1). With the alias present, stock m1n1 enables SIO, apple-sio initializes RTKit and SIO protocol v9, and DisplayPort audio becomes functional. Signed-off-by: HexCodeYT <indices-chants-7u@icloud.com>
muratcyberfu
pushed a commit
to muratcyberfu/linux
that referenced
this pull request
Sep 7, 2026
...ropagation Add multiple test cases for linked register tracking with alu32 ops: - Add a test that checks sync_linked_regs() regarding reg->id (the linked target register) for BPF_ADD_CONST32 rather than known_reg->id (the branch register). - Add a test case for linked register tracking that exposes the cross-type sync_linked_regs() bug. One register uses alu32 (w7 += 1, BPF_ADD_CONST32) and another uses alu64 (r8 += 2, BPF_ADD_CONST64), both linked to the same base register. - Add a test case that exercises regsafe() path pruning when two execution paths reach the same program point with linked registers carrying different ADD_CONST flags (BPF_ADD_CONST32 from alu32 vs BPF_ADD_CONST64 from alu64). This particular test passes with and without the fix since the pruning will fail due to different ranges, but it would still be useful to carry this one as a regression test for the unreachable div by zero. With the fix applied all the tests pass: # LDLIBS=-static PKG_CONFIG='pkg-config --static' ./vmtest.sh -- ./test_progs -t verifier_linked_scalars [...] ./test_progs -t verifier_linked_scalars AsahiLinux#602/1 verifier_linked_scalars/scalars: find linked scalars:OK AsahiLinux#602/2 verifier_linked_scalars/sync_linked_regs_preserves_id:OK AsahiLinux#602/3 verifier_linked_scalars/scalars_neg:OK AsahiLinux#602/4 verifier_linked_scalars/scalars_neg_sub:OK AsahiLinux#602/5 verifier_linked_scalars/scalars_neg_alu32_add:OK AsahiLinux#602/6 verifier_linked_scalars/scalars_neg_alu32_sub:OK AsahiLinux#602/7 verifier_linked_scalars/scalars_pos:OK AsahiLinux#602/8 verifier_linked_scalars/scalars_sub_neg_imm:OK AsahiLinux#602/9 verifier_linked_scalars/scalars_double_add:OK AsahiLinux#602/10 verifier_linked_scalars/scalars_sync_delta_overflow:OK AsahiLinux#602/11 verifier_linked_scalars/scalars_sync_delta_overflow_large_range:OK AsahiLinux#602/12 verifier_linked_scalars/scalars_alu32_big_offset:OK AsahiLinux#602/13 verifier_linked_scalars/scalars_alu32_basic:OK AsahiLinux#602/14 verifier_linked_scalars/scalars_alu32_wrap:OK AsahiLinux#602/15 verifier_linked_scalars/scalars_alu32_zext_linked_reg:OK AsahiLinux#602/16 verifier_linked_scalars/scalars_alu32_alu64_cross_type:OK AsahiLinux#602/17 verifier_linked_scalars/scalars_alu32_alu64_regsafe_pruning:OK AsahiLinux#602/18 verifier_linked_scalars/alu32_negative_offset:OK AsahiLinux#602/19 verifier_linked_scalars/spurious_precision_marks:OK AsahiLinux#602 verifier_linked_scalars:OK Summary: 1/19 PASSED, 0 SKIPPED, 0 FAILED Co-developed-by: Puranjay Mohan <puranjay@kernel.org> Signed-off-by: Puranjay Mohan <puranjay@kernel.org> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Acked-by: Eduard Zingerman <eddyz87@gmail.com> Link: https://lore.kernel.org/r/20260319211507.213816-2-daniel@iogearbox.net Signed-off-by: Alexei Starovoitov <ast@kernel.org>
jannau
commented
Sep 8, 2026
Member
thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
m1n1 looks up the SIO node through the
sioFDT alias when setting up SIO firmware data. The common T8103 device trees currently lack this alias, so m1n1 silently skips SIO setup and leaves the node disabled.Add the alias to
t8103-jxxx.dtsi, matching the T600x device trees.Tested on a J313 MacBook Air (M1) with stock m1n1 1.6.1.
Before this change:
/proc/device-tree/aliases/siois absentstatus = "disabled"dcp-dp-audioreportsNo DMA deviceWith this change:
/proc/device-tree/aliases/sioresolves to/soc/sio@236400000status = "okay"apple-sioinitializes RTKit successfully and reports SIO protocol v9appledrm.hdmi_audio=1,aplay -lexposesApple DisplayPortThe DTBs for J274, J293, J313, J456 and J457 build successfully with this change.