-
Notifications
You must be signed in to change notification settings - Fork 34
Expand pgm_read_... macros #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using arduino-1.8.8/hardware/tools/avr/avr/include/avr/pgmspace.h as reference.
ianfixes
commented
Jan 27, 2019
This looks awesome. When I was writing the mocks, I had no idea what the data types were supposed to be (or what precise macro could replace them) -- thank you for filling that in!
I assume this fixed a problem for you locally. Can you paste a snippet of (your) code that caused this compile error? I'd like to have that before I merge this, so I can write myself a note to add that unit test later. (You can write the full unit test if you want, but all I need is the example before I'll merge.)
hlovdal
commented
Jan 28, 2019
I assume this fixed a problem for you locally.
Actually no. I was just looking trough the existing issues, and though "This does not look too difficult to fix, let me have a try".
ianfixes
commented
Jan 28, 2019
Oh whoops, I was the one with this problem 🤦♂️. And I even wrote it down...
Highlights from
CHANGELOG.mdpgm_read_...preprocessor macros incpp/arduino/avr/pgmspace.hnow expands to an expression with applicable type.Issues Fixed
pgm_read_*macros #74