-
-
Notifications
You must be signed in to change notification settings - Fork 92
fix(gui): launch the agent helper via LaunchServices for a stable TCC identity#207
fix(gui): launch the agent helper via LaunchServices for a stable TCC identity #207davidbudnick wants to merge 1 commit into
Conversation
Greptile SummaryThis PR fixes the TCC identity mismatch (#192) by routing the packaged agent helper through LaunchServices (
Confidence Score: 4/5Safe to merge with awareness that the The core TCC fix is correct and well-tested for the happy path. The crates/openlogi-gui/src/ipc_client.rs — the Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[spawn_agent called] --> B[agent_binary_path]
B -->|None| C[warn: binary not found]
B -->|Some path| D[launch_agent]
D -->|macOS| E[helper_bundle path]
E -->|Some bundle| F["open -g -n bundle\nLaunchServices launch\nAgent gets own TCC identity"]
E -->|None dev binary| G["disclaim::Command\ndirect exec with TCC disclaimer"]
D -->|non-macOS| G
F --> H[Agent registers as\nOpenLogi Agent in TCC]
G --> I[Agent inherits or\ndisclaims GUI TCC identity]
Reviews (3): Last reviewed commit: "fix(gui): launch agent helper via Launch..." | Re-trigger Greptile |
9063e05 to
e2b0549
Compare
Uh oh!
There was an error while loading. Please reload this page.
Context
open(LaunchServices) so the agent is always its own responsible processTesting