Greptile Summary

This PR fixes solid-colour keyboard lighting on G-series keyboards by switching from the PerKeyLighting (0x8080) per-key stream — which the onboard firmware can silently override — to the ColorLedEffects (0x8070) effect engine, which replaces the running onboard profile. A clean fallback to 0x8080 covers devices that expose no effect engine.

• Adds LightingMethod (Auto/Effects/PerKey), set_keyboard_color_with(), and the private set_color_effects() helper that writes a fixed RAM-only effect to each zone with 8 ms inter-packet pacing; set_keyboard_color() becomes a thin Auto delegate.
• Extends the LIGHTING capabilities array to include 0x8070 so keyboards that expose ColorLedEffects (but not 0x8080) correctly show a Lighting tab in the GUI.
• Wires a --method flag into openlogi diag lighting for explicit A/B comparison; hardware-verified on a wired G513.

Confidence Score: 5/5

Safe to merge — the change is hardware-verified, the fallback path is correct, and existing callers of set_keyboard_color() are unaffected.

The Auto fallback correctly distinguishes a missing 0x8070 feature from any other error before falling through to 0x8080. Packet layout for the 0x8070 path is consistent with the HID++ 2.0 long-report structure, and the RAM-only persistence byte is the zero value so its exact offset is inconsequential. No callers are broken by the refactor.

crates/openlogi-cli/src/cmd/diag/lighting.rs — module doc still references 0x8080 as the primary path.

Important Files Changed

Sequence Diagram

sequenceDiagram
 participant CLI as diag lighting
 participant W as set_keyboard_color_with
 participant FI as resolve_feature_index
 participant E as set_color_effects (0x8070)
 participant PK as set_color_per_key (0x8080)
 participant HID as HID Device
 CLI->>W: "method=Auto, r, g, b"
 W->>E: r, g, b
 E->>FI: "feature_id=0x8070"
 FI->>HID: get_feature(0x8070)
 alt 0x8070 present
 HID-->>FI: feature index
 FI-->>E: Some(index)
 loop zones 0..4
 E->>HID: write_output_report (setZoneEffect, fixed, RAM-only)
 end
 E-->>W: Ok(())
 W-->>CLI: Ok(())
 else 0x8070 absent
 HID-->>FI: None
 FI-->>E: Ok(None)
 E-->>W: "Err(FeatureUnsupported{0x8070})"
 W->>PK: r, g, b (fallback)
 PK->>FI: "feature_id=0x8080"
 FI->>HID: get_feature(0x8080)
 HID-->>FI: feature index
 FI-->>PK: Some(index)
 loop key chunks
 PK->>HID: write_output_report (setGroupKeys)
 end
 PK->>HID: write_output_report (frameEnd)
 PK-->>W: Ok(())
 W-->>CLI: Ok(())
 end

_{Reviews (4): Last reviewed commit: "docs(hid): fix set_color_effects RAM-onl..." | Re-trigger Greptile}