Skip to content

Navigation Menu

Sign in
Sign up

Add zstd and Xcompression-level support - #1091

Open
ambyjkl wants to merge 1 commit into
AppImage:master from
ambyjkl:master
Open

Add zstd and Xcompression-level support #1091
ambyjkl wants to merge 1 commit into
AppImage:master from
ambyjkl:master

Conversation

@ambyjkl

@ambyjkl ambyjkl commented Nov 27, 2020

Copy link
Copy Markdown

Resolves #478

I've actually not tested this yet. Please let me know if this is what you're looking for.

Copy link
Copy Markdown
Member

I've actually not tested this yet. Please let me know if this is what you're looking for.

I have no idea why you would submit a PR with untested code. It almost seems like you think we don't have the few minutes to write that code, but we have the time to test yours. At least you're honest, which is very much appreciated.

I didn't bother looking into it too deeply. There's more than just one workflow issue with this PR. I don't think it makes sense to review this any further.

haampie and ruanformigoni reacted with confused emoji

ambyjkl commented Mar 23, 2021

Copy link
Copy Markdown
Author

Sorry I never got the chance to circle back. @TheAssassin sorry you feel that way, I didn't mean this PR to be an insult. I've never worked with this codebase before and I'm as busy as you are. I just wanted to understand if I'm headed in the right direction, so I can continue. If you don't have the time to help, feel free to close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use zstd compression

AltStyle によって変換されたページ (->オリジナル) /