-
Notifications
You must be signed in to change notification settings - Fork 2
Add negative input validation to factorial implementation #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AllThingsSmitty
merged 1 commit into
AllThingsSmitty:main
from
alphamyd:fix/add-negative-input-validation-to-factorial-implementation
Jun 3, 2025
Merged
Add negative input validation to factorial implementation #5
AllThingsSmitty
merged 1 commit into
AllThingsSmitty:main
from
alphamyd:fix/add-negative-input-validation-to-factorial-implementation
Jun 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...case optimization
I also updated the base case to handle both 0
and 1
directly, which avoids an unnecessary recursive call when n === 1
. It’s a small optimization, but it keeps the call stack cleaner and better matches the mathematical definition.
@AllThingsSmitty wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the existing
factorial(n)
function by adding input validation for negative numbers. Previously, callingfactorial(-1)
or any negative input would cause infinite recursion, eventually leading to a stack overflow. With this update, aRangeError
is thrown when a negative number is passed.Why this change is important:
RangeError
instead of a genericError
makes it immediately clear that the issue is with the range of acceptable values, not a syntax issue or unexpected type. According to MDN,RangeError
is appropriate when a value is not within the set or range of allowed values — which fits this case perfectly.The updated function stays concise and educational while being safer and more professional.