Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[pull] master from TheAlgorithms:master #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into AlgorithmAndLeetCode:master from TheAlgorithms:master
Sep 15, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Refactor Cycledetection.js and added it's test. (TheAlgorithms#1099)
  • Loading branch information
10kartik authored Sep 15, 2022
commit cf0593f4307749ae2c790f500f13f30aa91f23bc
24 changes: 8 additions & 16 deletions Data-Structures/Linked-List/CycleDetection.js
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,24 @@
/**
* A LinkedList based solution for Detect a Cycle in a list
* A LinkedList based solution for Detecting a Cycle in a list.
* https://en.wikipedia.org/wiki/Cycle_detection
*/

function main () {
function detectCycle (head) {
/*
Problem Statement:
Given head, the head of a linked list, determine if the linked list has a cycle in it.

Note:
* While Solving the problem in given link below, don't use main() function.
* Just use only the code inside main() function.
* The purpose of using main() function here is to avoid global variables.

Link for the Problem: https://leetcode.com/problems/linked-list-cycle/
*/
const head = '' // Reference to head is given in the problem. So please ignore this line
let fast = head
let slow = head
if (!head) { return false }

while (fast != null && fast.next != null && slow != null) {
let slow = head
let fast = head.next
while (fast && fast.next) {
if (fast === slow) { return true }
fast = fast.next.next
slow = slow.next
if (fast === slow) {
return true
}
}
return false
}

main()
export { detectCycle }
31 changes: 31 additions & 0 deletions Data-Structures/Linked-List/test/CycleDetection.test.js
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import { detectCycle } from '../CycleDetection'
import { Node } from '../SinglyLinkedList'

describe('Detect Cycle', () => {
it('should detect loop and return true', () => {
// Creating list and making a loop
const headNode = new Node(10)
headNode.next = new Node(20)
headNode.next.next = new Node(30)
headNode.next.next.next = new Node(40)
headNode.next.next.next.next = headNode
expect(detectCycle(headNode)).toEqual(true)
})

it('should not detect a loop and return false', () => {
// Case 0: When head is null, there is no loop.
expect(detectCycle(null)).toEqual(false)
const headNode = new Node(10)

// Case 1: List with single node doesn't have any loop
expect(detectCycle(headNode)).toEqual(false)

headNode.next = new Node(20)
headNode.next.next = new Node(30)
headNode.next.next.next = new Node(40)
headNode.next.next.next.next = new Node(50)

// Case 2: List not having any loops
expect(detectCycle(headNode)).toEqual(false)
})
})

AltStyle によって変換されたページ (->オリジナル) /