Skip to content

fix readonly issues in pandas #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft

stes wants to merge 2 commits into main

from stes/upgrade-pandas-torch

Draft

fix readonly issues in pandas #289

stes wants to merge 2 commits into main from stes/upgrade-pandas-torch

Conversation

Copy link

Member

@stes stes commented Jan 21, 2026 •

edited

Loading

fix readonly-issue in pandas, from 3.0.0 onwards Make CEBRA compatible with pandas 3.0.0 #287
upgrade build pipeline to latest torch -> errors/deprecation warnings still need to be resolved, see Upgrade to torch 2.10, resolve deprecation warnings #288

Fix #287


 fix readonly issues in pandas

98ef334

@cla-bot cla-bot bot added the CLA signed label


 upgrade build pipeline

2118a81

stes

stes commented

View reviewed changes

cebra/integrations/sklearn/dataset.py

Comment on lines +113 to +115

# Ensure array is writable (pandas 3.0+ may return read-only arrays)

if not X.flags.writeable:

X = X.copy()

Copy link

Member Author

@stes stes Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually not ideal... should work without as well, no need to actually modify the dataset within the sklearn API

@stes stes mentioned this pull request

Upgrade to latest pytest-sphinx on pypi #286

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants