-
Notifications
You must be signed in to change notification settings - Fork 26
Setup: Prevent encoding issue while installing package#5
Open
QuentinCG wants to merge 1 commit intoActiveState:master from
QuentinCG:master
Open
Setup: Prevent encoding issue while installing package #5QuentinCG wants to merge 1 commit intoActiveState:master from QuentinCG:master
QuentinCG wants to merge 1 commit intoActiveState:master from
QuentinCG:master
Conversation
Python opens files using the encoding returned by locale.getpreferredencoding(), which is 'cp1252' in Windows. For cross-platform compatibility, it is needed to explicitly specify 'utf-8' when reading files. File is also opened in read-only since it is not necessary to have write access to README and LICENCE files during install.
Author
QuentinCG
commented
Oct 5, 2019
Note: For python2.7+ compatibility, it is needed to add import io and use io.open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python opens files using the encoding returned by
locale.getpreferredencoding(), which is 'cp1252' in Windows.
For cross-platform compatibility, it is needed to explicitly
specify 'utf-8' when reading files.
File is also opened in read-only since it is not necessary
to have write access to README and NEWS files during install.