-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Moving HICs to use CMSIS UART Drivers #887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0Grit
commented
Nov 1, 2021
I love the smell of progress.
Contributor
tarokajya
commented
Nov 3, 2021
Just quick information. The original lpc55xx/uart.c contains typo around line 109.
case UART_DATA_BITS_7:
control |= ARM_USART_DATA_BITS_6;
break;
ARM_USART_DATA_BITS_6 has to be ARM_USART_DATA_BITS_7, I think.
mbrossard
added a commit
to mbrossard/DAPLink
that referenced
this pull request
Nov 4, 2021
Some spotted by @tarokajya in ARMmbed#887
Collaborator
mathias-arm
commented
Nov 4, 2021
@tarokajya: nice catch, I opened #888 for that (and other) typos.
mbrossard
added a commit
to mbrossard/DAPLink
that referenced
this pull request
Nov 8, 2021
Some spotted by @tarokajya in ARMmbed#887
mbrossard
added a commit
that referenced
this pull request
Nov 9, 2021
Some spotted by @tarokajya in #887
@mbrossard
mbrossard
force-pushed
the
feature/shared-cmsis-uart
branch
2 times, most recently
from
November 9, 2021 06:56
4e213a2 to
704b264
Compare
@mbrossard
mbrossard
force-pushed
the
feature/shared-cmsis-uart
branch
2 times, most recently
from
January 13, 2022 01:03
5e697d8 to
edde7af
Compare
gaborcsapo
pushed a commit
to gaborcsapo/DAPLink
that referenced
this pull request
Jun 29, 2022
Some spotted by @tarokajya in ARMmbed#887
gaborcsapo
pushed a commit
to gaborcsapo/DAPLink
that referenced
this pull request
Jun 29, 2022
Some spotted by @tarokajya in ARMmbed#887
gaborcsapo
pushed a commit
to gaborcsapo/DAPLink
that referenced
this pull request
Jun 29, 2022
Some spotted by @tarokajya in ARMmbed#887
@mbrossard
mbrossard
force-pushed
the
feature/shared-cmsis-uart
branch
from
February 15, 2023 03:30
edde7af to
c30aea6
Compare
@mbrossard
mbrossard
force-pushed
the
feature/shared-cmsis-uart
branch
4 times, most recently
from
February 15, 2024 04:39
133d0d0 to
0a66e0c
Compare
From lpc55xx HIC
@mbrossard
mbrossard
force-pushed
the
feature/shared-cmsis-uart
branch
from
February 28, 2025 03:01
0a66e0c to
02ba4f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @flit's work on
lpc55xx. Usingkl27zas an example.(ping @gerargz, @microbit-carlos)