-
Notifications
You must be signed in to change notification settings - Fork 818
fix: Treat equivalent pooling qinfo as non-requantized#1293
Open
morgolock wants to merge 1 commit into
Open
Conversation
CpuPool2dAssemblyWrapperKernel::configure() decided whether to use the requantized pooling path by comparing the raw QuantizationInfo objects, while validate() compared their normalized uniform() values. That made numerically equivalent qinfo such as QuantizationInfo(1.0f) and QuantizationInfo(1.0f, 0) take the slower differing-qinfo pooling path even though they represent the same scale and zero point. Use normalized qinfo equality for pooling dispatch as well, and add NEON pooling coverage for the equivalent-qinfo NHWC QASYMM8 padded MAX case. Signed-off-by: Pablo Marquez Tello <pablo.tello@arm.com> Change-Id: I54ab2cc9b2fae810b9d2767676097858eb8621c8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CpuPool2dAssemblyWrapperKernel::configure() decided whether to use the requantized pooling path by comparing the raw QuantizationInfo objects, while validate() compared their normalized uniform() values.
That made numerically equivalent qinfo such as QuantizationInfo(1.0f) and QuantizationInfo(1.0f, 0) take the slower differing-qinfo pooling path even though they represent the same scale and zero point.
Use normalized qinfo equality for pooling dispatch as well, and add NEON pooling coverage for the equivalent-qinfo NHWC QASYMM8 padded MAX case.
Change-Id: I54ab2cc9b2fae810b9d2767676097858eb8621c8