-
Notifications
You must be signed in to change notification settings - Fork 37
Open
Conversation
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #663.
This updates the catalogue schema, all existing dataset records, and the website consumers for the requested attribute changes.
What changed
Partialand theconversationsunitDomainvalues toSourceDomainvalues:General,Legal,News,Quran, andScienceCollection Styleto eithercrawlingormanual curationAnnotation Style, includingno annotationTest SplittoHas SplitsSubsetstoDialect SubsetsSubsetsfield for non-dialect dataset subsetsotheras an escape hatchMigration rules
SourceDomaindefaults toGeneral, with conservative classification for clear News, Quran, Legal, and Science recordsCollection Styleiscrawlingwhen crawling was previously present; otherwise it ismanual curationAnnotation Style; entries without an explicit annotation method useno annotation, while unknown values remainotherDialect Subsets; genericSubsetsstarts emptyPartial: falseValidation
USE_LOCAL_SCHEMA=true python validate_schema.pynode --checkon all modified JavaScript filespython -m py_compile validate_schema.py plots.pyTest SplitfieldJekyll rendering was not run because Ruby/Bundler is unavailable in the local environment.