Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: functions issue in nft dapp#348

Open
RutvikGhaskataEalf wants to merge 8 commits intodevelop from
fix/nft-tutorial
Open

fix: functions issue in nft dapp #348
RutvikGhaskataEalf wants to merge 8 commits intodevelop from
fix/nft-tutorial

Conversation

@RutvikGhaskataEalf
Copy link
Collaborator

@RutvikGhaskataEalf RutvikGhaskataEalf commented Dec 13, 2024

No description provided.

Copy link

vizipi bot commented Dec 13, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below ) Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00% vasmohi 9 1
100.00% yongenaelf 3 1
100.00% AelfHarsh 2 1

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
docs/quick-start/developers/dao-dapp/index.md 65.22%15 out of 23 times

Committed file ranks

(click to expand)
  • 96.34%[docs/quick-start/developers/nft-dapp/index.md]
  • Copy link
    Collaborator

    @yongenaelf yongenaelf Dec 26, 2024

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    handleerror?

    Copy link
    Collaborator

    @yongenaelf yongenaelf Dec 26, 2024

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    handleerror?

    Copy link
    Collaborator

    @yongenaelf yongenaelf Dec 26, 2024

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    handleerror?

    ### 4.3 Create NFT Collection on dAppChain

    :::tip
    i️ Note: This step cannot be executed via the command line interface (CLI).
    Copy link
    Collaborator

    @yongenaelf yongenaelf Jan 2, 2025

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    how should the user execute this step?

    Copy link
    Collaborator

    @yongenaelf yongenaelf Jan 2, 2025

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    why ignore?

    Copy link
    Collaborator

    @yongenaelf yongenaelf Jan 2, 2025
    edited
    Loading

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    ts

    Copy link
    Collaborator

    @yongenaelf yongenaelf Jan 2, 2025

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    ts

    Copy link
    Collaborator

    @yongenaelf yongenaelf Jan 2, 2025
    edited
    Loading

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    tsx

    Copy link
    Collaborator

    @yongenaelf yongenaelf Jan 2, 2025

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    tsx

    Copy link
    Collaborator

    @yongenaelf yongenaelf Jan 2, 2025

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    the

    Copy link
    Collaborator

    @yongenaelf yongenaelf Jan 2, 2025

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    tsx

    Copy link
    Collaborator

    @yongenaelf yongenaelf Jan 2, 2025

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    tsx

    Copy link
    Collaborator

    @yongenaelf yongenaelf Jan 2, 2025
    edited
    Loading

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    ts

    remove title="" if no title is needed

    Copy link
    Collaborator

    @yongenaelf yongenaelf Jan 2, 2025

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    dApp stands for "decentralised application", no need to add "application" after "dApp"

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @yongenaelf yongenaelf yongenaelf requested changes

    @vasmohi vasmohi Awaiting requested review from vasmohi

    Assignees

    No one assigned

    Labels

    None yet

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    Comments

    AltStyle によって変換されたページ (->オリジナル) /