-
Notifications
You must be signed in to change notification settings - Fork 260
Refactor: break down DeploySmartContract into smaller methods to improve readability#3448
Open
gldeng wants to merge 1 commit intofeature/deterministic-address from
Open
Refactor: break down DeploySmartContract into smaller methods to improve readability #3448gldeng wants to merge 1 commit intofeature/deterministic-address from
gldeng wants to merge 1 commit intofeature/deterministic-address from
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@ ## feature/deterministic-address #3448 +/- ## ================================================================= - Coverage 90.72% 81.25% -9.48% ================================================================= Files 663 664 +1 Lines 25388 25444 +56 Branches 2280 2282 +2 ================================================================= - Hits 23033 20674 -2359 - Misses 2239 4607 +2368 - Partials 116 163 +47
|
|
Pull request analysis by VIZIPI Below you will find who is the most qualified team member to review your code. Reviewers with knowledge related to these changes
Potential missing files from this Pull requestfiles commonly committed with a subset of this pr, but not committed this time. (click to collapse)
Committed file ranks |
@vizipi
vizipi
bot
requested review from
AbigailDeng,
YueZh127,
jason-aelf,
kaiwenzhengaelf,
ssun0121 and
zhxymh
September 21, 2023 07:36
@delete-merged-branch
delete-merged-branch
bot
deleted the branch
feature/deterministic-address
September 25, 2023 10:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.