Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed typos and grammatical errors.#3345

Open
jamaltheatlantean wants to merge 1 commit intoAElfProject:dev from
jamaltheatlantean:patch-1
Open

Fixed typos and grammatical errors. #3345
jamaltheatlantean wants to merge 1 commit intoAElfProject:dev from
jamaltheatlantean:patch-1

Conversation

@jamaltheatlantean
Copy link

@jamaltheatlantean jamaltheatlantean commented Dec 25, 2022

Removed the extra L in below, line 29. Added 'can be' in line 42. Deleted the e in similar, line 70.

Removed the extra L in below, line 29. Added 'can be' in line 42. Deleted the e in similar, line 70.
Copy link

vizipi bot commented Dec 25, 2022

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below ) Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00 % loning 16 1
100.00 % EanCuznaivy 4 1
100.00 % weili 2 1
100.00 % jason-hoopox 1 1

Potential missing files from this Pull request

No commonly committed files found with a 40% threashold


Committed file ranks

(click to expand)
  • 98.00%[README.md]
  • @vizipi vizipi bot requested review from jason-aelf and loning December 25, 2022 05:33
    Copy link

    codecov bot commented Dec 25, 2022

    Codecov Report

    Merging #3345 (15d90fb) into dev (46a4c5d) will decrease coverage by 19.08%.
    The diff coverage is n/a.

    Additional details and impacted files

    Impacted file tree graph

    @@ Coverage Diff @@
    ## dev #3345 +/- ##
    ===========================================
    - Coverage 91.11% 72.03% -19.09% 
    ===========================================
     Files 618 558 -60 
     Lines 23243 21692 -1551 
     Branches 2034 1915 -119 
    ===========================================
    - Hits 21178 15625 -5553 
    - Misses 1858 5558 +3700 
    - Partials 207 509 +302 
    Impacted Files Coverage Δ
    src/AElf.Kernel.Types/Chain/Chain.cs 0.00% <0.00%> (-100.00%) ⬇️
    src/AElf.Kernel.Types/KernelConstants.cs 0.00% <0.00%> (-100.00%) ⬇️
    src/AElf.CrossChain/CrossChainAElfModule.cs 0.00% <0.00%> (-100.00%) ⬇️
    src/AElf.OS.Core/Network/Application/Response.cs 0.00% <0.00%> (-100.00%) ⬇️
    src/AElf.Kernel/InitialSyncFinishedEventHandler.cs 0.00% <0.00%> (-100.00%) ⬇️
    ...c/AElf.CrossChain/Application/CrossChainService.cs 0.00% <0.00%> (-100.00%) ⬇️
    .../AElf.Kernel.SmartContract/StateProviderFactory.cs 0.00% <0.00%> (-100.00%) ⬇️
    .../AElf.Kernel/ConsensusRequestMiningEventHandler.cs 0.00% <0.00%> (-100.00%) ⬇️
    ...AElf.OS.Core/Network/Application/NetworkService.cs 0.00% <0.00%> (-100.00%) ⬇️
    ....Cryptography/Exceptions/EcdhOperationException.cs 0.00% <0.00%> (-100.00%) ⬇️
    ... and 307 more

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @loning loning Awaiting requested review from loning

    @jason-aelf jason-aelf Awaiting requested review from jason-aelf

    At least 2 approving reviews are required to merge this pull request.

    Assignees

    No one assigned

    Labels

    None yet

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    1 participant

    Comments

    AltStyle によって変換されたページ (->オリジナル) /