Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Enforce changelog entry on new PR #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tkan145 wants to merge 1 commit into 3scale:master
base: master
Choose a base branch
Loading
from tkan145:ci-changelog

Conversation

@tkan145
Copy link
Contributor

@tkan145 tkan145 commented Feb 2, 2026

What

Enfore changelog entry on new PR

@tkan145 tkan145 requested a review from a team as a code owner February 2, 2026 09:08
@josemigallas josemigallas changed the title (削除) Enfore changelog entry on new PR (削除ここまで) (追記) Enforce changelog entry on new PR (追記ここまで) Feb 3, 2026
- name: Check changelog existence
if: steps.changelog-file.outputs.any_changed == 'false'
run: |
echo("Please include a CHANGELOG entry. You can find it at [CHANGELOG.md](https://github.com/3scale/apicast/blob/master/CHANGELOG.md)."
Copy link

@josemigallas josemigallas Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo("Please include a CHANGELOG entry. You can find it at [CHANGELOG.md](https://github.com/3scale/apicast/blob/master/CHANGELOG.md)."
echo"Please include a CHANGELOG entry. You can find it at [CHANGELOG.md](https://github.com/3scale/apicast/blob/master/CHANGELOG.md)."


jobs:
require-changelog:
if: ${{ !contains(github.event.*.labels.*.name, 'skip-changelog') }}
Copy link

@josemigallas josemigallas Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be correct?

Suggested change
if: ${{ !contains(github.event.*.labels.*.name, 'skip-changelog') }}
if: ${{ !contains(github.event.pull_request.labels.*.name, 'skip-changelog') }}

Copy link
Contributor Author

@tkan145 tkan145 Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know 😄 , let me try

pull_request:
types: [ opened, synchronize, labeled, unlabeled ]
paths:
- 'gateway/**'
Copy link

@josemigallas josemigallas Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only gateway files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josemigallas josemigallas josemigallas left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /