-
Notifications
You must be signed in to change notification settings - Fork 448
fix: remove automatic file filter when clicking Review #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When clicking the Review button in the diff sidebar, a sub-chat filter was automatically applied (filteredSubChatIdAtom set to activeSubChatId), causing a "Filtered" badge to appear and hiding files not associated with the active sub-chat. This was confusing as users didn't expect or request the filtering. The review should operate on all changes by default; users can still manually apply a sub-chat filter if needed. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
filteredSubChatIdAtomto the active sub-chat, causing a "Filtered" badge to appear and hiding unrelated files — this was confusing and unexpectedTest plan
🤖 Generated with Claude Code