Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

make msgpack.Unpacker compatible with python2#226

Open
scorpioWalker wants to merge 1 commit into0rpc:master from
scorpioWalker:master
Open

make msgpack.Unpacker compatible with python2 #226
scorpioWalker wants to merge 1 commit into0rpc:master from
scorpioWalker:master

Conversation

@scorpioWalker
Copy link

@scorpioWalker scorpioWalker commented Dec 12, 2019

hi
I used zerorpc server with python2.
with msgpack==0.5.6, invoking methods from any client would make the server end raise an exception as below:

Traceback (most recent call last):
File "/opt/work/.pyenv/versions/mtas/lib/python2.7/site-packages/zerorpc/channel.py", line 78, in _channel_dispatcher
event = self._events.recv()
File "/opt/work/.pyenv/versions/mtas/lib/python2.7/site-packages/zerorpc/events.py", line 365, in recv
event = Event.unpack(get_pyzmq_frame_buffer(blob))
File "/opt/work/.pyenv/versions/mtas/lib/python2.7/site-packages/zerorpc/events.py", line 213, in unpack
unpacker = msgpack.Unpacker(raw=False)
File "msgpack/_unpacker.pyx", line 252, in msgpack._unpacker.Unpacker.init (msgpack/_unpacker.cpp:254)
TypeError: init() got an unexpected keyword argument 'raw'

and this obviously resulted from incompatible use of msgpack.Unpacker with arg 'raw' which could only be used in python3
so I made this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /