-
Notifications
You must be signed in to change notification settings - Fork 0
DT-157: Task manager — types & pure logic (WorkItem, Ticket, key/status/person functions) - #168
Merged
kigiri merged 2 commits intoAug 17, 2026
Conversation
4 tasks
@abdotop
abdotop
changed the title
(削除) DT-157:Task manager — types & pure logic (WorkItem, Ticket, key/status/person functions) (削除ここまで)
(追記) DT-157: Task manager — types & pure logic (WorkItem, Ticket, key/status/person functions) (追記ここまで)
Jul 27, 2026
kigiri
kigiri
reviewed
Jul 31, 2026
export const normalizeKey = (rawKey: string): string | undefined => {
const normalized = rawKey.toUpperCase().replace(/[^A-Z0-9]/g, '')
return KEY_SHAPE.test(normalized) ? normalized : undefined
}
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TNT-879-do-something would fail
/^([A-Z]+)[^0-9]?([0-9]+)/ would normalize all
[_, prefix, id] = 'TNT545-hey'.split(/^([A-Z]+)[^0-9]?([0-9]+)/) if (!id) return undefined `${prefix}${id}`
kigiri
kigiri
reviewed
Jul 31, 2026
return withoutKeyPrefix || github.title
}
return items[0].title
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here we could have a more generic "if this title has the project prefix clean it up" and not even care about the specific source
kigiri
kigiri
reviewed
Jul 31, 2026
): Ticket[] => {
const groups = Map.groupBy(
items,
(item) => extractKey(item) ?? `${item.source}:${item.externalId}`,
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`extractKey(item) || `${item.source}:${item.externalId}`
we don't want to accept falsy values as valid keys
kigiri
kigiri
reviewed
Jul 31, 2026
(ref.email != null && person.emails.includes(ref.email)) ||
(ref.discordId != null && person.discordId === ref.discordId) ||
(ref.jiraAccountId != null && person.jiraAccountId === ref.jiraAccountId)
)
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export const resolvePerson = (ref: PersonRef, person: Person) => (ref.login != null && person.githubLogin === ref.login) || (ref.email != null && person.emails.includes(ref.email)) || (ref.discordId != null && person.discordId === ref.discordId) || (ref.jiraAccountId != null && person.jiraAccountId === ref.jiraAccountId) ) function resolvePersonMethod(person: Person) { return resolvePerson(person, this) } directory.find(resolvePersonMethod, ref)
kigiri
kigiri
reviewed
Jul 31, 2026
const resolveUnique = (directory: Person[], refs: PersonRef[]): Person[] => {
const resolved = refs
.map((ref) => resolvePerson(directory, ref))
.filter((person): person is Person => person != null)
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const persons = new Set<Person>() for (const ref of refs) { const match = directory.find(resolvePerson, ref) match && persons.add(match) } return [...persons]
// if match ref is not stable: const persons = new Map<string, Person>() for (const ref of refs) { const match = directory.find(resolvePerson, ref) match && persons.set(match.id, match) } return [...persons.values()]
kigiri
kigiri
reviewed
Jul 31, 2026
reviewers: resolveUnique(
directory,
groupItems.flatMap((item) => item.reviewerRefs ?? []),
),
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolveUnique(directory, groupItems, 'reviewerRefs') // later const persons = new Set<Person>() for (const item of items) { if (!item[personKey]) continue for (const ref of item[personKey]) { const match = directory.find(resolvePerson, ref) match && persons.add(match) } } return [...persons]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement pure logic and types for task manager ticket aggregation