Skip to main content
Code Review

Return to Revisions

2 of 4
added code inline

split the individual validations and complete form validation. generalize the validations, something like here

$("#footer_newsletter").submit(function() {
 var invalidFields = checkForm({"type":"email","name":"some"},
 {"type":"field","name":"some2"});
 // mark fields in 'invalidFields'
});
function checkEmail (email) {
 //validate email and empty field
}
function checkField (field) {
 //validate field
}
function checkForm (jsonArray) {
 var invalidFieldsArray = new Array();
 for(field in jsonArray) {
 if(field.type == 'email') {
 if(checkEmail(field.name) {
 invalidFieldsArray.add(field.name);
 }
 } else if(field.type == 'field') {
 if(checkEmail(field.name) {
 invalidFieldsArray.add(field.name);
 }
 }
 }
} 
​

http://jsfiddle.net/6Y69Q/2/

default

AltStyle によって変換されたページ (->オリジナル) /