Skip to main content
Code Review

Return to Answer

added comments to code and made some other fixes
Source Link

split the individual validations and complete form validation. generalize the validations, something like here

$("#footer_newsletter").submit(function() {
 // send all fileds and their types to check form method 
  var invalidFields = checkForm({"type":"email","name":"some"},
 {"type":"field","name":"some2"});
 // markit returns only those fields inthat 'invalidFields'have invalid data
 // invalidFields var has array of names of fields with invalid data
 
});
function checkEmail (email) {
 //validate single email andfield, emptyreturn fieldtrue if it is a valid email
}
function checkField (field) {
 //validate single field to check if it is empty, return true if it is not empty
}
function checkForm (jsonArray) {
 var invalidFieldsArray = new Array();
 
 // loop through every field details and send it to respective filed validator methods
 for(field in jsonArray) {
 if(field.type == 'email') {
 // returns true if it is valid email
 if(! checkEmail(field.name) {
 // if invalid save to array
 invalidFieldsArray.add(field.name);
 }
 } else if(field.type == 'field') {
 // returns true if it is not empty
 if(! checkField(field.name) {
 // add to array if invalid
 invalidFieldsArray.add(field.name);
 }
 }
 }
return invalidFieldsArray;
} 
​

http://jsfiddle.net/6Y69Q/2/

split the individual validations and complete form validation. generalize the validations, something like here

$("#footer_newsletter").submit(function() {
 var invalidFields = checkForm({"type":"email","name":"some"},
 {"type":"field","name":"some2"});
 // mark fields in 'invalidFields'
});
function checkEmail (email) {
 //validate email and empty field
}
function checkField (field) {
 //validate field
}
function checkForm (jsonArray) {
 var invalidFieldsArray = new Array();
 for(field in jsonArray) {
 if(field.type == 'email') {
 if(checkEmail(field.name) {
 invalidFieldsArray.add(field.name);
 }
 } else if(field.type == 'field') {
 if(checkField(field.name) {
 invalidFieldsArray.add(field.name);
 }
 }
 }
} 
​

http://jsfiddle.net/6Y69Q/2/

split the individual validations and complete form validation. generalize the validations, something like here

$("#footer_newsletter").submit(function() {
 // send all fileds and their types to check form method 
  var invalidFields = checkForm({"type":"email","name":"some"},
 {"type":"field","name":"some2"});
 // it returns only those fields that have invalid data
 // invalidFields var has array of names of fields with invalid data
 
});
function checkEmail (email) {
 //validate single email field, return true if it is a valid email
}
function checkField (field) {
 //validate single field to check if it is empty, return true if it is not empty
}
function checkForm (jsonArray) {
 var invalidFieldsArray = new Array();
 
 // loop through every field details and send it to respective filed validator methods
 for(field in jsonArray) {
 if(field.type == 'email') {
 // returns true if it is valid email
 if(! checkEmail(field.name) {
 // if invalid save to array
 invalidFieldsArray.add(field.name);
 }
 } else if(field.type == 'field') {
 // returns true if it is not empty
 if(! checkField(field.name) {
 // add to array if invalid
 invalidFieldsArray.add(field.name);
 }
 }
 }
return invalidFieldsArray;
} 
​

http://jsfiddle.net/6Y69Q/2/

edited body
Source Link

split the individual validations and complete form validation. generalize the validations, something like here

$("#footer_newsletter").submit(function() {
 var invalidFields = checkForm({"type":"email","name":"some"},
 {"type":"field","name":"some2"});
 // mark fields in 'invalidFields'
});
function checkEmail (email) {
 //validate email and empty field
}
function checkField (field) {
 //validate field
}
function checkForm (jsonArray) {
 var invalidFieldsArray = new Array();
 for(field in jsonArray) {
 if(field.type == 'email') {
 if(checkEmail(field.name) {
 invalidFieldsArray.add(field.name);
 }
 } else if(field.type == 'field') {
 if(checkEmailcheckField(field.name) {
 invalidFieldsArray.add(field.name);
 }
 }
 }
} 
​

http://jsfiddle.net/6Y69Q/2/

split the individual validations and complete form validation. generalize the validations, something like here

$("#footer_newsletter").submit(function() {
 var invalidFields = checkForm({"type":"email","name":"some"},
 {"type":"field","name":"some2"});
 // mark fields in 'invalidFields'
});
function checkEmail (email) {
 //validate email and empty field
}
function checkField (field) {
 //validate field
}
function checkForm (jsonArray) {
 var invalidFieldsArray = new Array();
 for(field in jsonArray) {
 if(field.type == 'email') {
 if(checkEmail(field.name) {
 invalidFieldsArray.add(field.name);
 }
 } else if(field.type == 'field') {
 if(checkEmail(field.name) {
 invalidFieldsArray.add(field.name);
 }
 }
 }
} 
​

http://jsfiddle.net/6Y69Q/2/

split the individual validations and complete form validation. generalize the validations, something like here

$("#footer_newsletter").submit(function() {
 var invalidFields = checkForm({"type":"email","name":"some"},
 {"type":"field","name":"some2"});
 // mark fields in 'invalidFields'
});
function checkEmail (email) {
 //validate email and empty field
}
function checkField (field) {
 //validate field
}
function checkForm (jsonArray) {
 var invalidFieldsArray = new Array();
 for(field in jsonArray) {
 if(field.type == 'email') {
 if(checkEmail(field.name) {
 invalidFieldsArray.add(field.name);
 }
 } else if(field.type == 'field') {
 if(checkField(field.name) {
 invalidFieldsArray.add(field.name);
 }
 }
 }
} 
​

http://jsfiddle.net/6Y69Q/2/

added code inline
Source Link

split the individual validations and complete form validation. generalize the validations, something like here

$("#footer_newsletter").submit(function() {
 var invalidFields = checkForm({"type":"email","name":"some"},
 {"type":"field","name":"some2"});
 // mark fields in 'invalidFields'
});
function checkEmail (email) {
 //validate email and empty field
}
function checkField (field) {
 //validate field
}
function checkForm (jsonArray) {
 var invalidFieldsArray = new Array();
 for(field in jsonArray) {
 if(field.type == 'email') {
 if(checkEmail(field.name) {
 invalidFieldsArray.add(field.name);
 }
 } else if(field.type == 'field') {
 if(checkEmail(field.name) {
 invalidFieldsArray.add(field.name);
 }
 }
 }
} 
​

http://jsfiddle.net/6Y69Q/2/

split the individual validations and complete form validation. generalize the validations, something like here

http://jsfiddle.net/6Y69Q/2/

split the individual validations and complete form validation. generalize the validations, something like here

$("#footer_newsletter").submit(function() {
 var invalidFields = checkForm({"type":"email","name":"some"},
 {"type":"field","name":"some2"});
 // mark fields in 'invalidFields'
});
function checkEmail (email) {
 //validate email and empty field
}
function checkField (field) {
 //validate field
}
function checkForm (jsonArray) {
 var invalidFieldsArray = new Array();
 for(field in jsonArray) {
 if(field.type == 'email') {
 if(checkEmail(field.name) {
 invalidFieldsArray.add(field.name);
 }
 } else if(field.type == 'field') {
 if(checkEmail(field.name) {
 invalidFieldsArray.add(field.name);
 }
 }
 }
} 
​

http://jsfiddle.net/6Y69Q/2/

Source Link
Loading
default

AltStyle によって変換されたページ (->オリジナル) /