3
\$\begingroup\$

I am trying to have a Backbone.Model which is a singleton and I wish to instantiate it lazily. I only need to support modern browsers so please do not worry about the use of ES5 getter.

Is this the simplest way of achieving my goal?

var LazySingleton = function(){
 var _LazySingleton = Backbone.Model.extend({
 defaults: {
 foo: 0
 },
 initialize: function(){
 console.log('I am initializing');
 }
 });
 return {
 _instance: null,
 get instance() {
 if (this._instance === null) {
 this._instance = new _LazySingleton();
 }
 return this._instance;
 }
 };
}();
console.log('LazySingleton has been declared, but not initialized');
LazySingleton.instance.set('foo', 3); 
console.log('foo should be 3:', LazySingleton.instance.get('foo'));
Phrancis
20.5k6 gold badges69 silver badges155 bronze badges
asked Oct 15, 2014 at 17:48
\$\endgroup\$

1 Answer 1

2
\$\begingroup\$

This is not the simplest way.

  • There seems to be no point in instance, if there can be only 1 instance, why have it all ?
  • Why have initialize at all ?
  • Why set foo to 0, I would set it undefined
  • If I were to keep the instance concept, I would write this:

    _instance: null,
    get instance() {
     if (this._instance === null) {
     this._instance = new _LazySingleton();
     }
     return this._instance;
    }
    

    as

    _instance: null,
    get instance() {
     return this._instance = this._instance || new _LazySingleton();
    }
    

I would probably go for something like this ( I might have the syntax wrong )

var LazySingleton = Backbone.Model.extend({
 defaults: {
 foo: undefined
 },
 initialize: function(){
 });
answered Oct 15, 2014 at 20:53
\$\endgroup\$

Your Answer

Draft saved
Draft discarded

Sign up or log in

Sign up using Google
Sign up using Email and Password

Post as a guest

Required, but never shown

Post as a guest

Required, but never shown

By clicking "Post Your Answer", you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.