Best C# idiom to convert the items on an object array to a string?

Question

I have something akin to

object[] values = getValues();
string renderedValues = string.Join("-", 
 Array.ConvertAll<object,string>(values,
 new Converter<object,string>(o2s)
 ));

where o2s is

public static string o2s(object o) { return o.ToString(); }

Comments welcome!

Answer 1

There exists a method for that conversion already:

string renderedValues = string.Join(
 "-",
 Array.ConvertAll<object, string>(values, Convert.ToString)
);

---

Update:

In framework 4 an overload that takes an object array was added, so it will do the conversion for you:

string renderedValues = string.Join("-", values);

Answer 2

No need to create a new Converter. Also, I'd rename the variable:

object[] values = getValues();
string joinedValues = string.Join("-", Array.ConvertAll<object,string>(values, o2s));

• Jesse C. Slicer: what is o2s ?
• Bobby: @JesseC.Slicer: It's the function Vinko declares in the second half of the question.
• Jesse C. Slicer: Gotcha - for some reason my eyes didn't see that when I first read it. Thanks.

Answer 3

Why not (削除) Zoidberg (削除ここまで) simply this?

string renderedValues = string.Join("-", getValues());

Simply using the Join(string separator, params Object[] values) overload: http://msdn.microsoft.com/en-us/library/dd988350.aspx

• Vinko Vrsalovic: This overload an addition on 4 and I'm targeting 3.5
• JoeGeeky: Any idea how the two patterns compare from a performance standpoint. (Just assume .NET 4 was an option)
• ANeves: No idea whatsoever. Do you see any reason to spend time making code more complicated and less straightforward than it needs to be?