0
\$\begingroup\$

How can I make this code block shorter? I'm repeating myself, because of this prop cellRenderer.

{headers.map((header, i) => {
 return header.index ? (
 <Column
 label={header.label}
 dataKey={header.id}
 disableSort
 width={100}
 flexGrow={1}
 cellRenderer={this._generateCheckbox}
 />
 ) : (
 <Column
 label={header.label}
 dataKey={header.id}
 disableSort
 width={100}
 flexGrow={1}
 />
 );
})}
200_success
145k22 gold badges190 silver badges478 bronze badges
asked Sep 8, 2017 at 14:45
\$\endgroup\$

1 Answer 1

2
\$\begingroup\$

Passing undefined in for cellRenderer should be the same as not passing it in at all. Because of this, the duplication can be removed by doing the following:

{headers.map((header, i) => {
 return (
 <Column
 label={header.label}
 dataKey={header.id}
 disableSort
 width={100}
 flexGrow={1}
 cellRenderer={header.index ? this._generateCheckbox : undefined}
 />
 )
})}

Alternatively, you can build up an extraProps object and then spread it into the column.

{headers.map((header, i) => {
 let extraProps = header.index ? {
 cellRenderer: this._generateCheckbox
 } : {}
 return (
 <Column
 label={header.label}
 dataKey={header.id}
 disableSort
 width={100}
 flexGrow={1}
 {...extraProps}
 />
 )
})}
answered Sep 8, 2017 at 15:31
\$\endgroup\$

Your Answer

Draft saved
Draft discarded

Sign up or log in

Sign up using Google
Sign up using Email and Password

Post as a guest

Required, but never shown

Post as a guest

Required, but never shown

By clicking "Post Your Answer", you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.