1
\$\begingroup\$

I would like to know how I can improve this CakePHP 3.0 Component (inside folder controller)

1st: to use external libs (stored on vendor folder) I'm using the require keyword and include the class using use keyword, like this:

require_once(ROOT . DS . 'vendor' . DS . 'CakePHP-ImageTool-Component' . DS . 'ImageTool.php');

and

use ImageTool;

2nd: in method saveFileLFS I'm using true or false to flag OK.

<?php
namespace App\Controller\Component;
require_once(ROOT . DS . 'vendor' . DS . 'CakePHP-ImageTool-Component' . DS . 'ImageTool.php');
use Burzum\FileStorage\Lib\StorageManager;
use Cake\Controller\Component;
use ImageTool;
class UploadFileComponent extends Component
{
 function resizeImage($settings)
 {
 $status = ImageTool::resize([
 'input' => $settings['input'],
 'output' => $settings['output'],
 'width' => $settings['width'],
 'height' => $settings['height'],
 'mode' => $settings['mode']
 ]);
 return $status;
 }
 public function saveFileLFS($stringSeparator, $storeName, $productName)
 {
 $key = $storeName . $stringSeparator . $productName . $stringSeparator .
 $this->request->data['Media']['file']['name'];
 if(StorageManager::adapter('Local')->write($key,
 file_get_contents($this->request->data['Media']['file']['tmp_name']))){
 return true;
 }else
 {
 return false;
 }
 }
}
200_success
145k22 gold badges190 silver badges478 bronze badges
asked Dec 1, 2015 at 20:29
\$\endgroup\$
1

1 Answer 1

1
\$\begingroup\$

If you have another point to improve, please comment or answer, I will change the accepted answer

To change the require I use the composer.json classmap like this (follow this answer: Import Class without autoload and repository):

"autoload": {
 "classmap": [
 "./vendor/CakePHP-ImageTool-Component"
 ]
}

I don't use require now.

In saveFileLFS method now I'm using Exception if something don't work.

public function saveFileLFS($stringSeparator, $storeName, $productName)
{
 $key = $storeName . $stringSeparator . $productName . $stringSeparator .
 $this->request->data['Media']['file']['name'];
 if(!StorageManager::adapter('Local')->write($key,
 file_get_contents($this->request->data['Media']['file']['tmp_name']))){
 throw new MissingHelperException();
 //Or other Exception
 }
}
answered Dec 5, 2015 at 12:53
\$\endgroup\$

Your Answer

Draft saved
Draft discarded

Sign up or log in

Sign up using Google
Sign up using Email and Password

Post as a guest

Required, but never shown

Post as a guest

Required, but never shown

By clicking "Post Your Answer", you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.