Issues for GvR

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(166)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Id			Subject	Owner	Reviewers	Comments	Drafts	Last updated
Incoming reviews (64)
	66190043	Fix _UnixWritePipeTransport to support TTY	haypo_gmail	xdegaye, GvR	2		11 years
	168070043	Move loop attribute to _FlowControlMixin	haypo_gmail	Andrew Svetlov, GvR	2		11 years, 2 months
	148110044	Fix test_env_var_debug	yselivanov	GvR		11 years, 3 months
	145220043	call_at/call_later with Timer cancellation can result in (practically) unbounded memory usage	chatgris	gvrpython, yselivanov, GvR	21		11 years, 3 months
	131370043	BaseSelectorEventLoop.sock_connect() unregisters the socket on timeout	haypo_gmail	GvR	17		11 years, 4 months
	135910043	Fix a race condition in wait_for(), Tulip issue 201	haypo_gmail	GvR		11 years, 4 months
	116970044	Convert StreamWriter.drain() to a classic coroutine	haypo_gmail	GvR	2		11 years, 5 months
	113160044	Rewrite signal handling: use the self pipe	haypo_gmail	GvR	1		11 years, 5 months
	111730044	Make Server attributes and methods private	haypo_gmail	GvR		11 years, 6 months
	105570044	Handle.cancel() clears ref to callback and args; add "created at" to repr(Handle) in debug mode	haypo_gmail	GvR		11 years, 6 months
	110820049	Add asyncio.tasks.task_factory variable	haypo_gmail	yselivanov, GvR , songofacandy	7		11 years, 6 months
	69870048	Future.set_result is not safe	Nikolay Kim	GvR, haypo_gmail	5		11 years, 6 months
	110030043	Enable debug mode of event loops when PYTHONASYNCIODEBUG is set	haypo_gmail	GvR	4		11 years, 6 months
	108750043	Fill more XXX docstrings	haypo_gmail	GvR	2		11 years, 7 months
	98680044	Add BaseEventLoop._closed attribute	haypo_gmail	yselivanov, GvR	9		11 years, 7 months
	87940044	context_id for Task	yselivanov	GvR, haypo_gmail	30		11 years, 8 months
	67400043	Ensure call_soon() invoked on current loop when get_debug() enabled	davidfstr	gvrpython, yselivanov , GvR, haypo_gmail	29		11 years, 9 months
	69350045	Fix _TracebackLogger	haypo_gmail	yselivanov, GvR	7		11 years, 10 months
	72270043	Resolver API	haypo_gmail	yselivanov, GvR	18		11 years, 10 months
	67870052	Make test_events more reliable, avoid run_briefly	haypo_gmail	GvR	10		11 years, 10 months
	71360043	Windows socketpair()	haypo_gmail	GvR		11 years, 10 months
	71170043	Task._step() sets self to None even on exception	haypo_gmail	GvR		11 years, 10 months
	68620044	Replace unittest.mock with mock	haypo_gmail	yselivanov , GvR	1		11 years, 10 months
	68800045	drain(�) is a coroutine	haypo_gmail	GvR		11 years, 10 months
	66430046	docs refactoring	yselivanov	GvR	8		11 years, 10 months
	66640043	_check_resolved_address() accepts IPv6 address with only host and port	haypo_gmail	GvR		11 years, 10 months
	66650043	Add test test_communicate_after_exit(�)	haypo_gmail	GvR		11 years, 10 months
	64900043	Save the traceback where a Future/Task was created	haypo_gmail	yselivanov, GvR	7		11 years, 10 months
	65790043	Fix UNIX domain warnings	haypo_gmail	yselivanov , GvR		11 years, 10 months
	6870063	Don't mutate default values for properties	Cd-MaN	guido, GvR	12		13 years
	6903051	Add sanity check for the types of default values for (Local)StructuredProperty	Cd-MaN	guido, GvR	2		13 years, 1 month
	6590070	Fix reply by email not working again	JohnA	DO NOT USE, GvR, M-A		13 years, 3 months
	6500054	Show number of comments made by me beside total number of comments.	lazyboy	GvR, gvrpython	1		13 years, 3 months
	6494063	Fix reply by email for long subject lines	JohnA	GvR, gvrpython, M-A		13 years, 4 months
	5529052	upload.py detection for svn 1.7 (centralized .svn folder)	jocelyn.fiat	Andi Albrecht, techtonik , GvR	6		13 years, 12 months
	14053	Bazaar Support For upload.py	kevin.kubasik	Andi Albrecht, techtonik, GvR, bialix	8		14 years, 2 months
	5246060	Properties utility library: For custom properties	RafeKap	guido, GvR, beech	5		14 years, 2 months
	4368045	Rietveld patch to fix upload.py -r N:M failure on new directories	arkadi	Andi Albrecht, techtonik , GvR	8		14 years, 9 months
	4133046	Make json files known as a text mimetype so that they can be seen in reviews.	levin1	Andi Albrecht , GvR		14 years, 11 months
	3098041	Hook up implementation of showing a mildly prettified unified diff on the issue	Ilia Mirkin	GvR, gvrpython, imirkin		15 years, 1 month
	2341045	Clean up email formatting, add structured messages on issue page	Ilia Mirkin	Andi Albrecht, GvR, techtonik, gvrpython, imirkin		15 years, 1 month
	1515041	Injects the review server name in upload.py	Vincent Zanotti	Andi Albrecht , GvR	1		15 years, 7 months
	660042	Compatible numeric hashes	dickinsm	GvR, Christophe Simonis	14		15 years, 7 months
	1119042	Document use of 'upload.py --server' with full URL	icomfort	Andi Albrecht, GvR		15 years, 8 months
	696041	Allow the base URL to be a free-form string.	evan	Andi Albrecht , GvR	1		15 years, 9 months
	216058	Missing index from index.yaml	RafeChops	GvR		15 years, 10 months
	199067	Let Rietveld server-side code run on Python 2.4	icomfort	Andi Albrecht, GvR		15 years, 11 months
	151041	include line number in each change header in mail	rsc_swtch	GvR		16 years, 2 months
	126085	rietveld: an attempt at pubsubhubbub	rsc_swtch	GvR		16 years, 3 months
	115067	Message by XMPP instead of email when available	kaelog	parren, Nick Johnson, GvR, Andi Albrecht	44		16 years, 3 months
	110081	upload.py: special case mime-type for .mm files	evan	jam , GvR		16 years, 4 months
	104081	allow reviewers to edit issues	russcox	GvR		16 years, 5 months
	10072	Remember last used email address	sky1	JohnA, GvR		16 years, 5 months
	7888	Adding variable column width setting	georgedorn	Andi Albrecht, GvR	4		16 years, 5 months
	5674	[issue45] Explicitly sets FILE_UPLOAD_HANDLERS Django setting	MichaelHart	GvR		16 years, 5 months
	2918	Rietveld Search box	jiayao	Andi Albrecht, GvR	15		16 years, 5 months
	1026	base files uploading (works both over web and upload.py), Mercurial patches	ondrej.certik	Andi Albrecht, Antoine Pitrou, GvR	18		16 years, 5 months
	950	Google App Engine Django - Deserialize db.DateTimeProperty	mattbrown.nz	GvR	7		16 years, 5 months
	88059	Add support for 'private' issues in rietveld.	Nick Johnson	Andi Albrecht, GvR	25		16 years, 6 months
	68042	Separate VCS detection from VCS object creation.	ajwong	Andi Albrecht, GvR	4		16 years, 7 months
	40050	Make upload.py send svn cp'd and svn mv'd files correctly.	Collin Winter	Andi Albrecht, GvR	2		16 years, 9 months
	32080	[issue2578] additional unittest type equality methods	gregory.p.smith	GvR, fuzzyman	26		16 years, 9 months
	25073	[issue400608] just testing	ajaksu	GvR		16 years, 10 months
	20051	Minimal patch to secure the Python interpreter	asktav	GvR, Martin v. Löwis	13		16 years, 10 months
Outgoing reviews (2)
Id			Subject	Owner	Reviewers	Comments	Drafts	Last updated
	263300043	Tentative PEP 495 edits	GvR	sasha	19		10 years, 3 months
	69870043	Drop recommendation of extra blank line at end of docstring	GvR			11 years, 10 months
Unsent issues (1)
Id			Subject	Owner	Reviewers	Comments	Drafts	Last updated
	96620044	Optional exception argument to Future.cancel()	GvR			11 years, 7 months
Issues CCd to (2)
Id			Subject	Owner	Reviewers	Comments	Drafts	Last updated
	133890043	BaseEventLoop.call_exception_handler() now accepts a "source" key	haypo_gmail	yselivanov		11 years, 3 months
	109210043	Add traceback to the log "Coroutine never yielded"	haypo_gmail			11 years, 6 months
Closed Recently (0)
(None)

RSS Feeds Recent Issues

This is Rietveld f62528b

Issues for GvR

Incoming reviews (64)

Outgoing reviews (2)

Unsent issues (1)

Issues CCd to (2)

Closed Recently (0)