Issue 71360043: Windows socketpair()

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(27)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 71360043: Windows socketpair()

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by haypo_gmail

Modified:
11 years, 10 months ago

Reviewers:
GvR

Visibility:
Public.

More Reviews

Windows socketpair()

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -2 lines)			Patch
M	asyncio/windows_utils.py	View	1 chunk	+15 lines, -2 lines	0 comments	Download
M	tests/test_windows_utils.py	View	2 chunks	+12 lines, -0 lines	0 comments	Download

Total messages: 1

GvR

Can you modify the test for success to try both IP and IPv6 and not ...

11 years, 10 months ago (2014年03月05日 19:26:20 UTC) #1

Can you modify the test for success to try both IP and IPv6 and not mock out the
socket? The mocking seems to serve little purpose and runs the risk of enabling
code that doesn't actually work. Otherwise fine.