Issue 6903051: Add sanity check for the types of default values for (Local)StructuredProperty

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(234)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6903051: Add sanity check for the types of default values for (Local)StructuredProperty

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by Cd-MaN

Modified:
13 years, 1 month ago

Reviewers:
guido, GvR

CC:
appengine-ndb-discuss_googlegroups.com

Visibility:
Public.

More Reviews

Add sanity check for the types of default values for (Local)StructuredProperty

Patch Set 1 #

Total comments: 2

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -0 lines)			Patch
M	ndb/model.py	View	2 chunks	+8 lines, -0 lines	2 comments	Download
M	ndb/model_test.py	View	1 chunk	+30 lines, -0 lines	0 comments	Download

Total messages: 3

Cd-MaN

13 years, 1 month ago (2012年12月07日 19:37:58 UTC) #1

Cd-MaN

This is a part extracted from https://codereview.appspot.com/6870063/

13 years, 1 month ago (2012年12月07日 19:38:28 UTC) #2

This is a part extracted from https://codereview.appspot.com/6870063/

GvR

Almost looks good. https://codereview.appspot.com/6903051/diff/1/ndb/model.py File ndb/model.py (right): https://codereview.appspot.com/6903051/diff/1/ndb/model.py#newcode2071 ndb/model.py:2071: if self._default: is not None https://codereview.appspot.com/6903051/diff/1/ndb/model.py#newcode2342 ...

13 years, 1 month ago (2012年12月07日 20:15:19 UTC) #3

Almost looks good.
https://codereview.appspot.com/6903051/diff/1/ndb/model.py
File ndb/model.py (right):
https://codereview.appspot.com/6903051/diff/1/ndb/model.py#newcode2071
ndb/model.py:2071: if self._default:
is not None
https://codereview.appspot.com/6903051/diff/1/ndb/model.py#newcode2342
ndb/model.py:2342: if self._default:
is not None