Issue 66640043: _check_resolved_address() accepts IPv6 address with only host and port

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

(79)

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by haypo_gmail

Modified:
11 years, 10 months ago

Reviewers:
GvR

Visibility:
Public.

_check_resolved_address() accepts IPv6 address with only host and port

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
M	asyncio/base_events.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/test_events.py	View	1 chunk	+6 lines, -3 lines	0 comments	Download

Total messages: 2

GvR

LGTM. Thanks!

11 years, 10 months ago (2014年02月20日 19:54:43 UTC) #1

LGTM. Thanks!

haypo_gmail

On 2014年02月20日 19:54:43, GvR wrote: > LGTM. Thanks! Commited to Tulip (12ab9bba4bea) and Python (96e078663083). ...

11 years, 10 months ago (2014年02月20日 21:01:37 UTC) #2

On 2014年02月20日 19:54:43, GvR wrote:
> LGTM. Thanks!
Commited to Tulip (12ab9bba4bea) and Python (96e078663083). Poor Larry :-(