LGMT.
On Thu, Feb 20, 2014 at 12:14 AM, <victor.stinner@gmail.com> wrote:
> Reviewers: GvR,
>
>
>
> https://codereview.appspot.com/66190043/diff/1/asyncio/unix_events.py
> File asyncio/unix_events.py (right):
>
> https://codereview.appspot.com/66190043/diff/1/asyncio/
> unix_events.py#newcode346
> asyncio/unix_events.py:346: and not pipe.isatty()):
> On 2014年02月19日 23:12:21, GvR wrote:
>
>> I think this ought to be grouped differently, like so:
>>
>
> if <SOCKET> or (not <AIX> and not <TTY>):
>>
>
> Ah yes correct, fixed in new patch.
>
> Description:
> Fix _UnixWritePipeTransport to support TTY
>
> Please review this at https://codereview.appspot.com/66190043/
>
> Affected files (+32, -1 lines):
> M asyncio/unix_events.py
> A examples/tty.py
>
>
> Index: asyncio/unix_events.py
> ===================================================================
> --- a/asyncio/unix_events.py
> +++ b/asyncio/unix_events.py
> @@ -342,7 +342,8 @@ class _UnixWritePipeTransport(transports
> # On AIX, the reader trick only works for sockets.
> # On other platforms it works for pipes and sockets.
> # (Exception: OS X 10.4? Issue #19294.)
> - if is_socket or not sys.platform.startswith("aix"):
> + if (is_socket
> + or (not sys.platform.startswith("aix") and not
> pipe.isatty())):
> self._loop.add_reader(self._fileno, self._read_ready)
>
> self._loop.call_soon(self._protocol.connection_made, self)
> Index: examples/tty.py
> ===================================================================
> new file mode 100644
> --- /dev/null
> +++ b/examples/tty.py
> @@ -0,0 +1,30 @@
> +"""
> +Copy stdin into stdout, line by line.
> +"""
> +
> +import asyncio
> +import sys
> +from asyncio import streams
> +
> +class StdoutProtocol(streams.FlowControlMixin,
> + asyncio.Protocol):
> + pass
> +
> +@asyncio.coroutine
> +def copy_stdin_to_stdout():
> + reader = asyncio.StreamReader()
> + reader_protocol = asyncio.StreamReaderProtocol(reader)
> + yield from loop.connect_read_pipe(lambda: reader_protocol,
> + sys.stdin)
> + transport, protocol = yield from loop.connect_write_pipe(
> StdoutProtocol,
> + sys.stdout)
> + writer = streams.StreamWriter(transport, protocol, reader, loop)
> + while True:
> + line = yield from reader.readline()
> + if not line:
> + break
> + writer.write(line)
> + yield from writer.drain()
> +
> +loop = asyncio.get_event_loop()
> +loop.run_until_complete(copy_stdin_to_stdout())
>
>
>
-- 
--Guido van Rossum (python.org/~guido)