Keyboard Shortcuts

File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(97)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6494063: Fix reply by email for long subject lines

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by JohnA
Modified:
13 years, 4 months ago
Reviewers:
GvR, gvrpython, M-A
Visibility:
Public.
Fix reply by email for long subject lines. BUG=392

Patch Set 1 #

Created: 13 years, 4 months ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M codereview/views.py View 2 chunks +4 lines, -0 lines 0 comments Download
Total messages: 3
|
JohnA
This was bugging me enough that I download mercurial and started to use it :) ...
13 years, 4 months ago (2012年08月31日 02:10:24 UTC) #1
This was bugging me enough that I download mercurial and started to use it :)
Hopefully I can figure out how to land it and merge it to the chromium branch
successfully!
Sign in to reply to this message.
gvrpython
I'm getting ready for a trip. maruel should be able to help you. On Thu, ...
13 years, 4 months ago (2012年08月31日 02:27:40 UTC) #2
I'm getting ready for a trip. maruel should be able to help you.
On Thu, Aug 30, 2012 at 7:10 PM, <john.abdelmalek@gmail.com> wrote:
> Reviewers: GvR,
>
> Message:
> This was bugging me enough that I download mercurial and started to use
> it :) Hopefully I can figure out how to land it and merge it to the
> chromium branch successfully!
>
> Description:
> Fix reply by email for long subject lines.
>
> BUG=392
>
> Please review this at https://codereview.appspot.com/6494063/
>
> Affected files:
> M codereview/views.py
>
>
> Index: codereview/views.py
> ===================================================================
> --- a/codereview/views.py
> +++ b/codereview/views.py
> @@ -27,6 +27,7 @@
> import re
> import urllib
> from cStringIO import StringIO
> +from email.header import decode_header
> from xml.etree import ElementTree
>
> from google.appengine.api import mail
> @@ -3908,6 +3909,9 @@
> raise InvalidIncomingEmailError('Mail sent by App Engine')
>
> subject = incoming_msg.subject or ''
> + decoded_subject = decode_header(subject)
> + if decoded_subject[0][1]:
> + subject = decoded_subject[0][0].decode(decoded_subject[0][1])
> match = re.search(r'\(issue *(?P<id>\d+)\)$', subject)
> if match is None:
> raise InvalidIncomingEmailError('No issue id found: %s', subject)
>
>
-- 
--Guido van Rossum (python.org/~guido)
Sign in to reply to this message.
M-A
lgtm
13 years, 4 months ago (2012年08月31日 12:15:08 UTC) #3
lgtm
Sign in to reply to this message.
|
Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /