Keyboard Shortcuts

File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(83)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 25073: [issue400608] just testing

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 10 months ago by ajaksu
Modified:
16 years, 10 months ago
Reviewers:
GvR
CC:
report_bugs.python.org
Base URL:
http://rietveld.googlecode.com/svn/trunk/
Visibility:
Public.
wish we could expunge the deleted ones

Patch Set 1 #

Created: 16 years, 10 months ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -2 lines) Patch
M static/upload.py View 5 chunks +45 lines, -2 lines 0 comments Download
Total messages: 2
|
ajaksu
While this is a test issue, the attached diff is a crude first draft of ...
16 years, 10 months ago (2009年03月06日 04:52:50 UTC) #1
While this is a test issue, the attached diff is a crude first draft of a
patched upload.py that makes linking to the Python Tracker a bit easier.
Here's the command line and output:
$ python static/upload.py -R 400608 -F msg32813
Upload server: [...]
Loaded authentication cookies [...]
Issue created. URL: http://codereview.appspot.com/25073
Uploading base file for static/upload.py
And the help is:
$ python static/upload.py -h | tail -n5
 Link options:
 -R ROUNDUP, --roundup=ROUNDUP
 Python tracker issue number to link with.
 -F FETCHDESCR, --fetch_descr=FETCHDESCR
 Tracker file or message to fetch description from.
I like it :)
Sign in to reply to this message.
GvR
This is specific to the Python tracker, which Rietveld tries to avoid. You could maintain ...
16 years, 10 months ago (2009年03月06日 05:36:21 UTC) #2
This is specific to the Python tracker, which Rietveld tries to avoid. You
could maintain this as a locally modified version, but a better approach would
be to make just enough changes to upload.py itself so that you can write the
rest of this script as a *wrapper* around upload.py. That's how the Chrome
people manage their workflow, and that's a generally recommended approach: the
wrapper does the project-specific stuff, passing everything to upload.py for the
actual interaction with Rietveld.
PS. What do you mean by "wish we could expunge the deleted ones"? If you delete
a Rietveld issue it is really gone. If you merely close it, you can still
delete it later. But I'm probably missing something.
Sign in to reply to this message.
|
Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /