Issue 113160044: Rewrite signal handling: use the self pipe

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(305)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 113160044: Rewrite signal handling: use the self pipe

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by haypo_gmail

Modified:
11 years, 5 months ago

Reviewers:
GvR

Visibility:
Public.

More Reviews

Rewrite signal handling: use the self pipe

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -7 lines)			Patch
M	asyncio/proactor_events.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	asyncio/selector_events.py	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	asyncio/unix_events.py	View	4 chunks	+18 lines, -2 lines	1 comment	Download
M	tests/test_proactor_events.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/test_unix_events.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 1

GvR

LGTM https://codereview.appspot.com/113160044/diff/1/asyncio/unix_events.py File asyncio/unix_events.py (right): https://codereview.appspot.com/113160044/diff/1/asyncio/unix_events.py#newcode58 asyncio/unix_events.py:58: for signum in data: (Off-topic: This is a ...

11 years, 5 months ago (2014年07月17日 15:13:55 UTC) #1

LGTM
https://codereview.appspot.com/113160044/diff/1/asyncio/unix_events.py
File asyncio/unix_events.py (right):
https://codereview.appspot.com/113160044/diff/1/asyncio/unix_events.py#newcode58
asyncio/unix_events.py:58: for signum in data:
(Off-topic: This is a use case for bytes.__getitem__() returning an int! :-)