ziglang/zig
266
6.0k
Fork
You've already forked zig
786

std.math.pow: replace Go port with musl algorithm #36058

Open
paulofduarte wants to merge 2 commits from paulofduarte/std-math-pow-musl into master AGit
pull from: paulofduarte/std-math-pow-musl
merge into: ziglang:master
ziglang:master
ziglang:elfv2
ziglang:spork8
ziglang:restricted
ziglang:0.16.x
ziglang:panic-rewrite
ziglang:parking-futex-lockfree
ziglang:windows-Io-cleanup
ziglang:Io-watch
ziglang:ParseCommandLineOptions
ziglang:windows-async-files
ziglang:poll-ring
ziglang:debug-file-leaks-differently
ziglang:debug-file-leaks
ziglang:ProcessPrng
ziglang:elfv2-dyn
ziglang:jobserver
ziglang:threadtheft
ziglang:io-threaded-no-queue
ziglang:0.15.x
ziglang:Io.net
ziglang:comptime-allocator
ziglang:restricted-function-pointers
ziglang:cli
ziglang:wasm-linker-writer
ziglang:wrangle-writer-buffering
ziglang:sha1-stream
ziglang:async-await-demo
ziglang:fixes
ziglang:0.14.x
ziglang:ast-node-methods
ziglang:macos-debug-info
ziglang:make-vs-configure
ziglang:fuzz-macos
ziglang:sans-aro
ziglang:ArrayList-reserve
ziglang:incr-bug
ziglang:llvm-ir-nosanitize-metadata
ziglang:ci-tarballs
ziglang:ci-scripts
ziglang:threadpool
ziglang:0.12.x
ziglang:new-pkg-hash
ziglang:json-diagnostics
ziglang:more-doctests
ziglang:rework-comptime-mutation
ziglang:0.11.x
ziglang:ci-perf-comment
ziglang:stage2-async
ziglang:0.10.x
ziglang:autofix
ziglang:0.9.x
ziglang:aro
ziglang:hcs
ziglang:0.8.x
ziglang:0.7.x
First-time contributor
Copy link

Replaces the 2017 Go port of std.math.pow (the last one in std.math) with the musl algorithm (ARM optimized-routines, also used by glibc). The Go algorithm exponentiates by squaring per exponent bit, which roughly doubles the relative error with every significant bit of the exponent (golang/go#25270). This is the same problem that caused the bundled libc pow to be reverted to musl C in #31794 (see also #31207).

  • f64: faithful port of musl's pow, with both the fma and non-fma code paths, selected at comptime like musl's __FP_FAST_FMA.
  • f16 (new) and f32: computed as exp2(y * log2(|x|)) in f64 with a single rounding to the result type.
  • C99 special-case layer unchanged; f80/f128 remain TODO.

Validation, against a 128-bit MPFR reference using the methodology of Gladman/Innocente/Zimmermann, "Accuracy of Mathematical Functions":

  • over 8M bit-space samples, f64 max error improves from 2777.9 ulp to 0.505 ulp and f32 from 860.6 ulp to 0.500 ulp, with zero results off by more than 1 ulp (previously 62737). Targeted probing of the old algorithm shows the error passing tens of millions of ulps as the exponent gains bits; the new maximum stays within musl's analytical bound of 0.54 ulp, and the known worst case of this code base measures 0.522908 ulp, matching the published 0.523.
  • bit-identical to the vendored musl pow.c compiled with zig cc, over 8M bit-space samples on each of the fma and non-fma paths.
  • special-case truth table (+-0, +-1, +-inf, nan, subnormals, odd/even/non-integer/huge/tiny exponents) passes for f16/f32/f64 and matches musl bit for bit on f64; nan results keep Zig's canonical NaN, matching existing std.math behavior, rather than musl's payload propagation.
  • one test expectation corrected: pow(f32, 89.123, 3.3) is 2722489.75 when correctly rounded; the old value encoded the Go algorithm's error.
Replaces the 2017 Go port of `std.math.pow` (the last one in `std.math`) with the musl algorithm (ARM optimized-routines, also used by glibc). The Go algorithm exponentiates by squaring per exponent bit, which roughly doubles the relative error with every significant bit of the exponent ([golang/go#25270](https://github.com/golang/go/issues/25270)). This is the same problem that caused the bundled libc `pow` to be reverted to musl C in #31794 (see also #31207). * `f64`: faithful port of musl's `pow`, with both the fma and non-fma code paths, selected at comptime like musl's `__FP_FAST_FMA`. * `f16` (new) and `f32`: computed as `exp2(y * log2(|x|))` in `f64` with a single rounding to the result type. * C99 special-case layer unchanged; `f80`/`f128` remain `TODO`. Validation, against a 128-bit MPFR reference using the methodology of Gladman/Innocente/Zimmermann, ["Accuracy of Mathematical Functions"](https://homepages.loria.fr/pzimmermann/papers/glibc238-20230921.pdf): * over 8M bit-space samples, `f64` max error improves from 2777.9 ulp to 0.505 ulp and `f32` from 860.6 ulp to 0.500 ulp, with zero results off by more than 1 ulp (previously 62737). Targeted probing of the old algorithm shows the error passing tens of millions of ulps as the exponent gains bits; the new maximum stays within musl's analytical bound of 0.54 ulp, and the known worst case of this code base measures 0.522908 ulp, matching the published 0.523. * bit-identical to the vendored musl `pow.c` compiled with `zig cc`, over 8M bit-space samples on each of the fma and non-fma paths. * special-case truth table (`+-0`, `+-1`, `+-inf`, `nan`, subnormals, odd/even/non-integer/huge/tiny exponents) passes for `f16`/`f32`/`f64` and matches musl bit for bit on `f64`; `nan` results keep Zig's canonical NaN, matching existing `std.math` behavior, rather than musl's payload propagation. * one test expectation corrected: `pow(f32, 89.123, 3.3)` is 2722489.75 when correctly rounded; the old value encoded the Go algorithm's error.
paulofduarte changed title from (削除) std.math.pow: replace Go port with musl algorithm (削除ここまで) to WIP: std.math.pow: replace Go port with musl algorithm 2026年07月05日 23:40:21 +02:00
paulofduarte force-pushed paulofduarte/std-math-pow-musl from 8d6448eff9
Some checks failed
ci / aarch64-macos-release (pull_request) Successful in 1h6m0s
ci / x86_64-freebsd-release (pull_request) Successful in 47m36s
ci / x86_64-freebsd-debug (pull_request) Successful in 51m2s
ci / x86_64-netbsd-debug (pull_request) Successful in 54m18s
ci / x86_64-netbsd-release (pull_request) Successful in 53m42s
ci / aarch64-macos-debug (pull_request) Successful in 1h23m48s
ci / x86_64-openbsd-debug (pull_request) Successful in 1h8m19s
ci / aarch64-linux-release (pull_request) Successful in 1h42m49s
ci / x86_64-openbsd-release (pull_request) Successful in 1h1m13s
ci / powerpc64le-linux-release (pull_request) Successful in 2h26m13s
ci / x86_64-windows-release (pull_request) Successful in 1h33m41s
ci / x86_64-windows-debug (pull_request) Successful in 1h42m44s
ci / aarch64-linux-debug (pull_request) Successful in 2h46m43s
ci / s390x-linux-release (pull_request) Successful in 1h39m58s
ci / x86_64-linux-debug (pull_request) Successful in 1h27m41s
ci / s390x-linux-debug (pull_request) Successful in 2h41m7s
ci / powerpc64le-linux-debug (pull_request) Successful in 4h15m4s
ci / x86_64-linux-release (pull_request) Successful in 4h7m18s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 4h48m43s
ci / aarch64-freebsd-debug (pull_request) Has been cancelled
ci / aarch64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-netbsd-debug (pull_request) Has been cancelled
ci / aarch64-netbsd-release (pull_request) Has been cancelled
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
to 62568b88d9
All checks were successful
ci / x86_64-freebsd-release (pull_request) Successful in 46m8s
ci / x86_64-netbsd-release (pull_request) Successful in 49m56s
ci / x86_64-freebsd-debug (pull_request) Successful in 50m47s
ci / x86_64-openbsd-release (pull_request) Successful in 54m5s
ci / x86_64-netbsd-debug (pull_request) Successful in 54m14s
ci / x86_64-windows-release (pull_request) Successful in 1h2m43s
ci / x86_64-openbsd-debug (pull_request) Successful in 1h3m7s
ci / x86_64-windows-debug (pull_request) Successful in 1h11m34s
ci / aarch64-macos-release (pull_request) Successful in 1h12m29s
ci / aarch64-macos-debug (pull_request) Successful in 1h23m33s
ci / x86_64-linux-debug (pull_request) Successful in 1h27m26s
ci / s390x-linux-release (pull_request) Successful in 1h31m36s
ci / aarch64-linux-release (pull_request) Successful in 1h43m42s
ci / powerpc64le-linux-release (pull_request) Successful in 2h28m5s
ci / aarch64-linux-debug (pull_request) Successful in 3h13m42s
ci / s390x-linux-debug (pull_request) Successful in 3h30m50s
ci / powerpc64le-linux-debug (pull_request) Successful in 3h38m27s
ci / x86_64-linux-release (pull_request) Successful in 4h8m46s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 4h10m41s
ci / aarch64-freebsd-debug (pull_request) Has been skipped
ci / aarch64-freebsd-release (pull_request) Has been skipped
ci / aarch64-netbsd-debug (pull_request) Has been skipped
ci / aarch64-netbsd-release (pull_request) Has been skipped
ci / loongarch64-linux-release (pull_request) Successful in 2h40m17s
ci / loongarch64-linux-debug (pull_request) Successful in 3h46m5s
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
2026年07月06日 01:28:33 +02:00
Compare
Author
First-time contributor
Copy link

Had ported musl's powf for improved f32 performance. Now it doesn't use exp2(y * log2(|x|)) but it's own dedicated pow32 function. f16 is casted for the pow32.

I would like to offer my help in case there is any plan to turn std.math.pow into a builtin function @pow.

Had ported musl's powf for improved f32 performance. Now it doesn't use `exp2(y * log2(|x|))` but it's own dedicated pow32 function. f16 is casted for the pow32. I would like to offer my help in case there is any plan to turn std.math.pow into a builtin function `@pow`.
paulofduarte changed title from (削除) WIP: std.math.pow: replace Go port with musl algorithm (削除ここまで) to std.math.pow: replace Go port with musl algorithm 2026年07月06日 01:45:34 +02:00
All checks were successful
ci / x86_64-freebsd-release (pull_request) Successful in 46m8s
Required
Details
ci / x86_64-netbsd-release (pull_request) Successful in 49m56s
Required
Details
ci / x86_64-freebsd-debug (pull_request) Successful in 50m47s
Required
Details
ci / x86_64-openbsd-release (pull_request) Successful in 54m5s
Required
Details
ci / x86_64-netbsd-debug (pull_request) Successful in 54m14s
Required
Details
ci / x86_64-windows-release (pull_request) Successful in 1h2m43s
Required
Details
ci / x86_64-openbsd-debug (pull_request) Successful in 1h3m7s
Required
Details
ci / x86_64-windows-debug (pull_request) Successful in 1h11m34s
Required
Details
ci / aarch64-macos-release (pull_request) Successful in 1h12m29s
Required
Details
ci / aarch64-macos-debug (pull_request) Successful in 1h23m33s
Required
Details
ci / x86_64-linux-debug (pull_request) Successful in 1h27m26s
Required
Details
ci / s390x-linux-release (pull_request) Successful in 1h31m36s
Required
Details
ci / aarch64-linux-release (pull_request) Successful in 1h43m42s
Required
Details
ci / powerpc64le-linux-release (pull_request) Successful in 2h28m5s
Required
Details
ci / aarch64-linux-debug (pull_request) Successful in 3h13m42s
Required
Details
ci / s390x-linux-debug (pull_request) Successful in 3h30m50s
Required
Details
ci / powerpc64le-linux-debug (pull_request) Successful in 3h38m27s
Required
Details
ci / x86_64-linux-release (pull_request) Successful in 4h8m46s
Required
Details
ci / x86_64-linux-debug-llvm (pull_request) Successful in 4h10m41s
Required
Details
ci / aarch64-freebsd-debug (pull_request) Has been skipped
ci / aarch64-freebsd-release (pull_request) Has been skipped
ci / aarch64-netbsd-debug (pull_request) Has been skipped
ci / aarch64-netbsd-release (pull_request) Has been skipped
ci / loongarch64-linux-release (pull_request) Successful in 2h40m17s
ci / loongarch64-linux-debug (pull_request) Successful in 3h46m5s
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin +refs/pull/36058/head:paulofduarte/std-math-pow-musl
git switch paulofduarte/std-math-pow-musl
Sign in to join this conversation.
No reviewers
Labels
Clear labels
abi/f32
abi/ilp32
abi/sf
accepted
This proposal is planned.
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
The web application for interactive documentation and generation of its assets.
backend/c
The C backend outputs C source code.
backend/llvm
The LLVM backend outputs an LLVM bitcode module.
backend/self-hosted
The self-hosted backends produce machine code directly.
binutils
Zig's included binary utilities: zig ar, zig dlltool, zig lib, zig ranlib, zig objcopy, and zig rc.
breaking
Implementing this issue could cause existing code to no longer compile or have different behavior.
build system
The Zig build system - zig build, std.Build, the build runner, and package management.
debug info
An issue related to debug information (e.g. DWARF) produced by the Zig compiler.
docs
An issue with documentation, e.g. the language reference or standard library doc comments.
error message
This issue points out an error message that is unhelpful and should be improved.
frontend
Tokenization, parsing, AstGen, ZonGen, Sema, Legalize, and Liveness.
fuzzing
An issue related to Zig's integrated fuzz testing.
incremental
Reuse of internal compiler state for faster compilation.
lib/c
This issue relates to Zig's libc implementation and/or vendored libcs.
lib/compiler-rt
This issue relates to Zig's compiler-rt library.
lib/cxx
This issue relates to Zig's vendored libc++ and/or libc++abi.
lib/std
This issue relates to Zig's standard library.
lib/tsan
This issue relates to Zig's vendored libtsan.
lib/ubsan-rt
This issue relates to Zig's ubsan-rt library.
lib/unwind
This issue relates to Zig's vendored libunwind.
linking
Zig's integrated object file and incremental linker.
miscompilation
The compiler reports success but produces semantically incorrect code.
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
This issue suggests language modifications. If it also has the "accepted" label then it is planned.
release notes
This issue or pull request should be mentioned in the release notes.
testing
This issue is related to testing the compiler, standard library, or other parts of Zig.
zig cc
Zig as a drop-in C-family compiler.
zig fmt
The Zig source code formatter.
zig reduce
The Zig source code reduction tool.
bounty
https://ziglang.org/news/announcing-donor-bounties
bug
Observed behavior contradicts documented or intended behavior.
contributor-friendly
This issue is limited in scope and/or knowledge of project internals.
downstream
An issue with a third-party project that uses this project.
enhancement
Solving this issue will likely involve adding new logic or components to the codebase.
infra
An issue related to project infrastructure, e.g. continuous integration.
optimization
A task to improve performance and/or resource usage.
question
No questions on the issue tracker; use a community space instead.
regression
Something that used to work in a previous version stopped working
upstream
An issue with a third-party project that this project uses.
use case
Describes a real use case that is difficult or impossible, but does not propose a solution.
No labels
abi/f32
abi/ilp32
abi/sf
accepted
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
backend/c
backend/llvm
backend/self-hosted
binutils
breaking
build system
debug info
docs
error message
frontend
fuzzing
incremental
lib/c
lib/compiler-rt
lib/cxx
lib/std
lib/tsan
lib/ubsan-rt
lib/unwind
linking
miscompilation
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
release notes
testing
zig cc
zig fmt
zig reduce
bounty
bug
contributor-friendly
downstream
enhancement
infra
optimization
question
regression
upstream
use case
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ziglang/zig!36058
Reference in a new issue
ziglang/zig
No description provided.
Delete branch "paulofduarte/std-math-pow-musl"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?