ziglang/zig
262
5.9k
Fork
You've already forked zig
763

compiler: implement @divCeil builtin #36043

Merged
andrewrk merged 6 commits from pavelverigo/zig:div-ceil into master 2026年07月08日 21:15:29 +02:00

Third time's the charm.

pull/16807
pull/21757

Added co-author from the previous pull requests.

(削除) I'll wait for CI to pass before updating stage1.wasm and the compiler. (削除ここまで)

One controversial thing I decided to add is expand_div_ceil in legalize to support x86_64. There was no existing logic (like for @divFloor), so this was implemented from scratch. In the future it'll probably either be removed or kept if it proves useful for other backends.

Closes github/16022

Third time's the charm. [pull/16807](https://github.com/ziglang/zig/pull/16807) [pull/21757](https://github.com/ziglang/zig/pull/21757) Added co-author from the previous pull requests. ~~I'll wait for CI to pass before updating `stage1.wasm` and the compiler.~~ One controversial thing I decided to add is `expand_div_ceil` in legalize to support `x86_64`. There was no existing logic (like for `@divFloor`), so this was implemented from scratch. In the future it'll probably either be removed or kept if it proves useful for other backends. Closes [github/16022](https://github.com/ziglang/zig/issues/16022)
pavelverigo force-pushed div-ceil from 229257bf4a
Some checks failed
ci / aarch64-freebsd-debug (pull_request) Has been cancelled
ci / aarch64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-netbsd-debug (pull_request) Has been cancelled
ci / aarch64-netbsd-release (pull_request) Has been cancelled
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
ci / x86_64-netbsd-release (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
ci / x86_64-windows-release (pull_request) Has been cancelled
ci / aarch64-linux-debug (pull_request) Has been cancelled
ci / x86_64-windows-debug (pull_request) Has been cancelled
ci / x86_64-linux-release (pull_request) Has been cancelled
ci / aarch64-macos-release (pull_request) Has been cancelled
ci / aarch64-linux-release (pull_request) Has been cancelled
ci / x86_64-openbsd-release (pull_request) Has been cancelled
ci / x86_64-openbsd-debug (pull_request) Has been cancelled
ci / x86_64-linux-debug (pull_request) Has been cancelled
ci / aarch64-macos-debug (pull_request) Has been cancelled
ci / x86_64-netbsd-debug (pull_request) Has been cancelled
ci / x86_64-linux-debug-llvm (pull_request) Has been cancelled
ci / x86_64-freebsd-release (pull_request) Has been cancelled
ci / x86_64-freebsd-debug (pull_request) Has been cancelled
ci / s390x-linux-debug (pull_request) Has been cancelled
ci / s390x-linux-release (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
to 83828bb461
Some checks failed
ci / x86_64-netbsd-release (pull_request) Failing after 30m27s
ci / x86_64-freebsd-release (pull_request) Failing after 31m3s
ci / aarch64-freebsd-debug (pull_request) Has been cancelled
ci / aarch64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-netbsd-debug (pull_request) Has been cancelled
ci / aarch64-netbsd-release (pull_request) Has been cancelled
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
ci / x86_64-linux-release (pull_request) Has been cancelled
ci / aarch64-macos-release (pull_request) Has been cancelled
ci / x86_64-freebsd-debug (pull_request) Has been cancelled
ci / x86_64-windows-debug (pull_request) Has been cancelled
ci / aarch64-macos-debug (pull_request) Has been cancelled
ci / x86_64-windows-release (pull_request) Has been cancelled
ci / x86_64-linux-debug-llvm (pull_request) Has been cancelled
ci / aarch64-linux-release (pull_request) Has been cancelled
ci / x86_64-linux-debug (pull_request) Has been cancelled
ci / aarch64-linux-debug (pull_request) Has been cancelled
ci / x86_64-netbsd-debug (pull_request) Has been cancelled
ci / x86_64-openbsd-release (pull_request) Has been cancelled
ci / x86_64-openbsd-debug (pull_request) Has been cancelled
ci / s390x-linux-debug (pull_request) Has been cancelled
ci / s390x-linux-release (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
2026年07月04日 18:56:08 +02:00 Compare
pavelverigo force-pushed div-ceil from 83828bb461
Some checks failed
ci / x86_64-netbsd-release (pull_request) Failing after 30m27s
ci / x86_64-freebsd-release (pull_request) Failing after 31m3s
ci / aarch64-freebsd-debug (pull_request) Has been cancelled
ci / aarch64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-netbsd-debug (pull_request) Has been cancelled
ci / aarch64-netbsd-release (pull_request) Has been cancelled
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
ci / x86_64-linux-release (pull_request) Has been cancelled
ci / aarch64-macos-release (pull_request) Has been cancelled
ci / x86_64-freebsd-debug (pull_request) Has been cancelled
ci / x86_64-windows-debug (pull_request) Has been cancelled
ci / aarch64-macos-debug (pull_request) Has been cancelled
ci / x86_64-windows-release (pull_request) Has been cancelled
ci / x86_64-linux-debug-llvm (pull_request) Has been cancelled
ci / aarch64-linux-release (pull_request) Has been cancelled
ci / x86_64-linux-debug (pull_request) Has been cancelled
ci / aarch64-linux-debug (pull_request) Has been cancelled
ci / x86_64-netbsd-debug (pull_request) Has been cancelled
ci / x86_64-openbsd-release (pull_request) Has been cancelled
ci / x86_64-openbsd-debug (pull_request) Has been cancelled
ci / s390x-linux-debug (pull_request) Has been cancelled
ci / s390x-linux-release (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
to a8e05b8cc3
All checks were successful
ci / x86_64-freebsd-release (pull_request) Successful in 47m10s
ci / x86_64-freebsd-debug (pull_request) Successful in 52m36s
ci / x86_64-netbsd-release (pull_request) Successful in 53m32s
ci / x86_64-windows-release (pull_request) Successful in 56m8s
ci / x86_64-openbsd-release (pull_request) Successful in 56m36s
ci / x86_64-netbsd-debug (pull_request) Successful in 59m50s
ci / x86_64-openbsd-debug (pull_request) Successful in 1h2m50s
ci / aarch64-macos-release (pull_request) Successful in 1h11m29s
ci / x86_64-windows-debug (pull_request) Successful in 1h16m50s
ci / x86_64-linux-debug (pull_request) Successful in 1h20m29s
ci / aarch64-macos-debug (pull_request) Successful in 1h28m27s
ci / aarch64-linux-release (pull_request) Successful in 1h50m24s
ci / s390x-linux-release (pull_request) Successful in 1h58m50s
ci / powerpc64le-linux-release (pull_request) Successful in 2h2m33s
ci / s390x-linux-debug (pull_request) Successful in 2h44m8s
ci / x86_64-linux-release (pull_request) Successful in 2h52m14s
ci / aarch64-linux-debug (pull_request) Successful in 3h15m36s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 3h30m6s
ci / powerpc64le-linux-debug (pull_request) Successful in 6h20m42s
ci / aarch64-freebsd-debug (pull_request) Has been skipped
ci / aarch64-freebsd-release (pull_request) Has been skipped
ci / aarch64-netbsd-debug (pull_request) Has been skipped
ci / aarch64-netbsd-release (pull_request) Has been skipped
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / loongarch64-linux-debug (pull_request) Successful in 3h45m38s
ci / loongarch64-linux-release (pull_request) Successful in 2h28m42s
2026年07月04日 19:29:06 +02:00 Compare
andrewrk left a comment
Copy link

Nice work

Nice work

@pavelverigo wrote in #36043 (comment):

I'll wait for CI to pass before updating stage1.wasm and the compiler.

Do you need to update stage1.wasm? In general it's better to avoid doing it where possible.

@pavelverigo wrote in https://codeberg.org/ziglang/zig/pulls/36043#issue-6112874: > I'll wait for CI to pass before updating `stage1.wasm` and the compiler. Do you need to update stage1.wasm? In general it's better to avoid doing it where possible.
Author
Member
Copy link

@andrewrk wrote in #36043 (comment):

Do you need to update stage1.wasm?

I want to use @divCeil inside the compiler (Sema/arith.zig) + I am planning to update math.divCeil it may be used in compiler already.

@andrewrk wrote in https://codeberg.org/ziglang/zig/pulls/36043#issuecomment-18575120: > Do you need to update stage1.wasm? I want to use `@divCeil` inside the compiler (`Sema/arith.zig`) + I am planning to update `math.divCeil` it may be used in compiler already.
Contributor
Copy link

I suggest to also handle this TODO from src/main.zig:

// TODO: The `align(@alignOf(std.heap.SafeAllocator))` can be removed the next time zig1.wasm is updated`

I previosly suggeted this here: #30875 (comment), but I think this PR will be merged way sooner.

I suggest to also handle this TODO from `src/main.zig`: ``` // TODO: The `align(@alignOf(std.heap.SafeAllocator))` can be removed the next time zig1.wasm is updated` ``` --- I previosly suggeted this here: https://codeberg.org/ziglang/zig/pulls/30875#issuecomment-18294419, but I think this PR will be merged way sooner.
pavelverigo force-pushed div-ceil from a8e05b8cc3
All checks were successful
ci / x86_64-freebsd-release (pull_request) Successful in 47m10s
ci / x86_64-freebsd-debug (pull_request) Successful in 52m36s
ci / x86_64-netbsd-release (pull_request) Successful in 53m32s
ci / x86_64-windows-release (pull_request) Successful in 56m8s
ci / x86_64-openbsd-release (pull_request) Successful in 56m36s
ci / x86_64-netbsd-debug (pull_request) Successful in 59m50s
ci / x86_64-openbsd-debug (pull_request) Successful in 1h2m50s
ci / aarch64-macos-release (pull_request) Successful in 1h11m29s
ci / x86_64-windows-debug (pull_request) Successful in 1h16m50s
ci / x86_64-linux-debug (pull_request) Successful in 1h20m29s
ci / aarch64-macos-debug (pull_request) Successful in 1h28m27s
ci / aarch64-linux-release (pull_request) Successful in 1h50m24s
ci / s390x-linux-release (pull_request) Successful in 1h58m50s
ci / powerpc64le-linux-release (pull_request) Successful in 2h2m33s
ci / s390x-linux-debug (pull_request) Successful in 2h44m8s
ci / x86_64-linux-release (pull_request) Successful in 2h52m14s
ci / aarch64-linux-debug (pull_request) Successful in 3h15m36s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 3h30m6s
ci / powerpc64le-linux-debug (pull_request) Successful in 6h20m42s
ci / aarch64-freebsd-debug (pull_request) Has been skipped
ci / aarch64-freebsd-release (pull_request) Has been skipped
ci / aarch64-netbsd-debug (pull_request) Has been skipped
ci / aarch64-netbsd-release (pull_request) Has been skipped
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / loongarch64-linux-debug (pull_request) Successful in 3h45m38s
ci / loongarch64-linux-release (pull_request) Successful in 2h28m42s
to 00fd7090ef
Some checks failed
ci / aarch64-freebsd-debug (pull_request) Has been skipped
ci / aarch64-freebsd-release (pull_request) Has been skipped
ci / aarch64-netbsd-debug (pull_request) Has been skipped
ci / aarch64-netbsd-release (pull_request) Has been skipped
ci / x86_64-linux-debug-llvm (pull_request) Failing after 35m4s
ci / x86_64-linux-debug (pull_request) Failing after 36m16s
ci / x86_64-linux-release (pull_request) Failing after 38m22s
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
ci / aarch64-macos-debug (pull_request) Has been cancelled
ci / x86_64-openbsd-debug (pull_request) Has been cancelled
ci / aarch64-linux-debug (pull_request) Has been cancelled
ci / x86_64-openbsd-release (pull_request) Has been cancelled
ci / aarch64-linux-release (pull_request) Has been cancelled
ci / x86_64-netbsd-debug (pull_request) Has been cancelled
ci / x86_64-netbsd-release (pull_request) Has been cancelled
ci / x86_64-freebsd-release (pull_request) Has been cancelled
ci / x86_64-freebsd-debug (pull_request) Has been cancelled
ci / x86_64-windows-release (pull_request) Has been cancelled
ci / s390x-linux-release (pull_request) Has been cancelled
ci / x86_64-windows-debug (pull_request) Has been cancelled
ci / aarch64-macos-release (pull_request) Has been cancelled
ci / s390x-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
2026年07月06日 13:12:24 +02:00 Compare
Author
Member
Copy link

@K4 Done.

@K4 Done.
pavelverigo force-pushed div-ceil from 00fd7090ef
Some checks failed
ci / aarch64-freebsd-debug (pull_request) Has been skipped
ci / aarch64-freebsd-release (pull_request) Has been skipped
ci / aarch64-netbsd-debug (pull_request) Has been skipped
ci / aarch64-netbsd-release (pull_request) Has been skipped
ci / x86_64-linux-debug-llvm (pull_request) Failing after 35m4s
ci / x86_64-linux-debug (pull_request) Failing after 36m16s
ci / x86_64-linux-release (pull_request) Failing after 38m22s
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
ci / aarch64-macos-debug (pull_request) Has been cancelled
ci / x86_64-openbsd-debug (pull_request) Has been cancelled
ci / aarch64-linux-debug (pull_request) Has been cancelled
ci / x86_64-openbsd-release (pull_request) Has been cancelled
ci / aarch64-linux-release (pull_request) Has been cancelled
ci / x86_64-netbsd-debug (pull_request) Has been cancelled
ci / x86_64-netbsd-release (pull_request) Has been cancelled
ci / x86_64-freebsd-release (pull_request) Has been cancelled
ci / x86_64-freebsd-debug (pull_request) Has been cancelled
ci / x86_64-windows-release (pull_request) Has been cancelled
ci / s390x-linux-release (pull_request) Has been cancelled
ci / x86_64-windows-debug (pull_request) Has been cancelled
ci / aarch64-macos-release (pull_request) Has been cancelled
ci / s390x-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
to d17bd29726
Some checks failed
ci / aarch64-freebsd-debug (pull_request) Has been skipped
ci / aarch64-netbsd-debug (pull_request) Has been skipped
ci / aarch64-freebsd-release (pull_request) Has been skipped
ci / aarch64-netbsd-release (pull_request) Has been skipped
ci / aarch64-macos-release (pull_request) Failing after 4m5s
ci / x86_64-linux-release (pull_request) Failing after 4m34s
ci / x86_64-windows-debug (pull_request) Failing after 6m17s
ci / x86_64-netbsd-release (pull_request) Failing after 6m3s
ci / x86_64-linux-debug-llvm (pull_request) Failing after 5m51s
ci / x86_64-netbsd-debug (pull_request) Failing after 6m32s
ci / x86_64-linux-debug (pull_request) Failing after 6m29s
ci / x86_64-freebsd-release (pull_request) Failing after 5m58s
ci / s390x-linux-release (pull_request) Failing after 6m48s
ci / x86_64-freebsd-debug (pull_request) Failing after 6m13s
ci / x86_64-openbsd-release (pull_request) Failing after 7m13s
ci / s390x-linux-debug (pull_request) Failing after 8m7s
ci / x86_64-openbsd-debug (pull_request) Failing after 8m3s
ci / x86_64-windows-release (pull_request) Failing after 7m45s
ci / aarch64-macos-debug (pull_request) Failing after 9m22s
ci / aarch64-linux-debug (pull_request) Failing after 9m48s
ci / aarch64-linux-release (pull_request) Failing after 8m51s
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
2026年07月06日 13:57:17 +02:00 Compare
pavelverigo force-pushed div-ceil from d17bd29726
Some checks failed
ci / aarch64-freebsd-debug (pull_request) Has been skipped
ci / aarch64-netbsd-debug (pull_request) Has been skipped
ci / aarch64-freebsd-release (pull_request) Has been skipped
ci / aarch64-netbsd-release (pull_request) Has been skipped
ci / aarch64-macos-release (pull_request) Failing after 4m5s
ci / x86_64-linux-release (pull_request) Failing after 4m34s
ci / x86_64-windows-debug (pull_request) Failing after 6m17s
ci / x86_64-netbsd-release (pull_request) Failing after 6m3s
ci / x86_64-linux-debug-llvm (pull_request) Failing after 5m51s
ci / x86_64-netbsd-debug (pull_request) Failing after 6m32s
ci / x86_64-linux-debug (pull_request) Failing after 6m29s
ci / x86_64-freebsd-release (pull_request) Failing after 5m58s
ci / s390x-linux-release (pull_request) Failing after 6m48s
ci / x86_64-freebsd-debug (pull_request) Failing after 6m13s
ci / x86_64-openbsd-release (pull_request) Failing after 7m13s
ci / s390x-linux-debug (pull_request) Failing after 8m7s
ci / x86_64-openbsd-debug (pull_request) Failing after 8m3s
ci / x86_64-windows-release (pull_request) Failing after 7m45s
ci / aarch64-macos-debug (pull_request) Failing after 9m22s
ci / aarch64-linux-debug (pull_request) Failing after 9m48s
ci / aarch64-linux-release (pull_request) Failing after 8m51s
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
to 485f45b1c7
Some checks failed
ci / aarch64-freebsd-debug (pull_request) Has been skipped
ci / aarch64-netbsd-debug (pull_request) Has been skipped
ci / aarch64-freebsd-release (pull_request) Has been skipped
ci / aarch64-netbsd-release (pull_request) Has been skipped
ci / aarch64-macos-release (pull_request) Successful in 58m9s
ci / x86_64-freebsd-release (pull_request) Successful in 1h0m8s
ci / x86_64-freebsd-debug (pull_request) Successful in 1h1m57s
ci / x86_64-netbsd-release (pull_request) Successful in 1h9m19s
ci / x86_64-netbsd-debug (pull_request) Successful in 1h15m6s
ci / x86_64-openbsd-release (pull_request) Successful in 1h20m11s
ci / x86_64-linux-debug (pull_request) Successful in 1h20m13s
ci / x86_64-openbsd-debug (pull_request) Successful in 1h23m35s
ci / x86_64-windows-release (pull_request) Successful in 1h28m39s
ci / x86_64-windows-debug (pull_request) Successful in 1h41m27s
ci / aarch64-linux-release (pull_request) Successful in 1h51m58s
ci / powerpc64le-linux-release (pull_request) Successful in 2h2m55s
ci / s390x-linux-release (pull_request) Successful in 1h32m33s
ci / aarch64-macos-debug (pull_request) Successful in 2h27m5s
ci / s390x-linux-debug (pull_request) Successful in 2h41m54s
ci / aarch64-linux-debug (pull_request) Successful in 2h57m8s
ci / x86_64-linux-release (pull_request) Successful in 3h19m7s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 4h56m41s
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
2026年07月06日 14:09:48 +02:00 Compare
jacobly left a comment
Copy link

I'm less worried about the non-optimizing backends as long as they pass tests, including:

--- a/test/behavior/x86_64/binary.zig
+++ b/test/behavior/x86_64/binary.zig
@@ -5279,6 +5279,27 @@ test divFloorOptimized {
 try test_div_floor_optimized.testFloatVectors();
 }
 
+inline fn divCeilUnoptimized(comptime Type: type, lhs: Type, rhs: Type) Type {
+ return @divCeil(lhs, rhs);
+}
+test divCeilUnoptimized {
+ const test_div_ceil_unoptimized = binary(divCeilUnoptimized, .{ .compare = .approx_int });
+ try test_div_ceil_unoptimized.testInts();
+ try test_div_ceil_unoptimized.testIntVectors();
+ try test_div_ceil_unoptimized.testFloats();
+ try test_div_ceil_unoptimized.testFloatVectors();
+}
+
+inline fn divCeilOptimized(comptime Type: type, lhs: Type, rhs: Type) Type {
+ @setFloatMode(.optimized);
+ return @divCeil(lhs, select(@abs(rhs) > splat(Type, 0.0), rhs, splat(Type, 1.0)));
+}
+test divCeilOptimized {
+ const test_div_ceil_optimized = binary(divCeilOptimized, .{ .compare = .approx_int });
+ try test_div_ceil_optimized.testFloats();
+ try test_div_ceil_optimized.testFloatVectors();
+}
+
I'm less worried about the non-optimizing backends as long as they pass tests, including: ```diff --- a/test/behavior/x86_64/binary.zig +++ b/test/behavior/x86_64/binary.zig @@ -5279,6 +5279,27 @@ test divFloorOptimized { try test_div_floor_optimized.testFloatVectors(); } +inline fn divCeilUnoptimized(comptime Type: type, lhs: Type, rhs: Type) Type { + return @divCeil(lhs, rhs); +} +test divCeilUnoptimized { + const test_div_ceil_unoptimized = binary(divCeilUnoptimized, .{ .compare = .approx_int }); + try test_div_ceil_unoptimized.testInts(); + try test_div_ceil_unoptimized.testIntVectors(); + try test_div_ceil_unoptimized.testFloats(); + try test_div_ceil_unoptimized.testFloatVectors(); +} + +inline fn divCeilOptimized(comptime Type: type, lhs: Type, rhs: Type) Type { + @setFloatMode(.optimized); + return @divCeil(lhs, select(@abs(rhs) > splat(Type, 0.0), rhs, splat(Type, 1.0))); +} +test divCeilOptimized { + const test_div_ceil_optimized = binary(divCeilOptimized, .{ .compare = .approx_int }); + try test_div_ceil_optimized.testFloats(); + try test_div_ceil_optimized.testFloatVectors(); +} + ```
@ -3581,0 +3629,4 @@
constrhs_sign=tryself.wip.bin(.@"and",rhs,smin,"divCeil.rhs_sign");
constrem_xor_rhs_sign=tryself.wip.bin(.xor,rem,rhs_sign,"divCeil.rem_xor_rhs_sign");
constsame_sign=tryself.wip.icmp(.ult,rem_xor_rhs_sign,smin,"divCeil.same_sign");
Owner
Copy link

Please don't use this complicated expression if you aren't going to fold in the comparison of rem with zero, why are you clearing unobserved bits in rhs, why are you using an unsigned comparison? I believe just using .sgt, rem_xor_rhs_sign, zero here properly accounts for the rem_nonzero check.

Please don't use this complicated expression if you aren't going to fold in the comparison of `rem` with zero, why are you clearing unobserved bits in `rhs`, why are you using an unsigned comparison? I believe just using `.sgt, rem_xor_rhs_sign, zero` here properly accounts for the `rem_nonzero` check.
Author
Member
Copy link

I arrived at this by modifying the divFloor lowering above and mechanically applying the rem != 0 and same_sign logic to it, without fully thinking through the smin trick. You right, .sgt will indeed be equivalent to that 3 lines. For unsigned comparison point again that was from divFloor.

I arrived at this by modifying the `divFloor` lowering above and mechanically applying the `rem != 0 and same_sign` logic to it, without fully thinking through the `smin` trick. You right, `.sgt` will indeed be equivalent to that 3 lines. For unsigned comparison point again that was from `divFloor`.
Author
Member
Copy link

I will push new version in coming hours.

I will push new version in coming hours.
pavelverigo marked this conversation as resolved
pavelverigo force-pushed div-ceil from 485f45b1c7
Some checks failed
ci / aarch64-freebsd-debug (pull_request) Has been skipped
ci / aarch64-netbsd-debug (pull_request) Has been skipped
ci / aarch64-freebsd-release (pull_request) Has been skipped
ci / aarch64-netbsd-release (pull_request) Has been skipped
ci / aarch64-macos-release (pull_request) Successful in 58m9s
ci / x86_64-freebsd-release (pull_request) Successful in 1h0m8s
ci / x86_64-freebsd-debug (pull_request) Successful in 1h1m57s
ci / x86_64-netbsd-release (pull_request) Successful in 1h9m19s
ci / x86_64-netbsd-debug (pull_request) Successful in 1h15m6s
ci / x86_64-openbsd-release (pull_request) Successful in 1h20m11s
ci / x86_64-linux-debug (pull_request) Successful in 1h20m13s
ci / x86_64-openbsd-debug (pull_request) Successful in 1h23m35s
ci / x86_64-windows-release (pull_request) Successful in 1h28m39s
ci / x86_64-windows-debug (pull_request) Successful in 1h41m27s
ci / aarch64-linux-release (pull_request) Successful in 1h51m58s
ci / powerpc64le-linux-release (pull_request) Successful in 2h2m55s
ci / s390x-linux-release (pull_request) Successful in 1h32m33s
ci / aarch64-macos-debug (pull_request) Successful in 2h27m5s
ci / s390x-linux-debug (pull_request) Successful in 2h41m54s
ci / aarch64-linux-debug (pull_request) Successful in 2h57m8s
ci / x86_64-linux-release (pull_request) Successful in 3h19m7s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 4h56m41s
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
to b4c4939043
All checks were successful
ci / aarch64-freebsd-debug (pull_request) Has been skipped
ci / aarch64-freebsd-release (pull_request) Has been skipped
ci / aarch64-netbsd-release (pull_request) Has been skipped
ci / aarch64-netbsd-debug (pull_request) Has been skipped
ci / aarch64-macos-release (pull_request) Successful in 59m21s
ci / x86_64-freebsd-debug (pull_request) Successful in 58m17s
ci / x86_64-linux-debug (pull_request) Successful in 57m49s
ci / aarch64-macos-debug (pull_request) Successful in 1h22m19s
ci / x86_64-netbsd-release (pull_request) Successful in 1h7m37s
ci / x86_64-netbsd-debug (pull_request) Successful in 1h18m28s
ci / x86_64-freebsd-release (pull_request) Successful in 39m38s
ci / x86_64-openbsd-debug (pull_request) Successful in 1h24m29s
ci / x86_64-openbsd-release (pull_request) Successful in 1h16m55s
ci / aarch64-linux-release (pull_request) Successful in 1h50m9s
ci / powerpc64le-linux-release (pull_request) Successful in 2h19m29s
ci / x86_64-windows-debug (pull_request) Successful in 1h49m26s
ci / x86_64-windows-release (pull_request) Successful in 1h29m53s
ci / aarch64-linux-debug (pull_request) Successful in 3h1m18s
ci / x86_64-linux-release (pull_request) Successful in 3h46m34s
ci / s390x-linux-release (pull_request) Successful in 1h28m1s
ci / powerpc64le-linux-debug (pull_request) Successful in 4h52m22s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 4h53m11s
ci / s390x-linux-debug (pull_request) Successful in 2h56m8s
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / loongarch64-linux-release (pull_request) Successful in 2h17m37s
ci / loongarch64-linux-debug (pull_request) Successful in 3h47m36s
2026年07月06日 20:50:13 +02:00 Compare
Author
Member
Copy link

I rebuild stage1.wasm again, as compiler commit changed.

I rebuild `stage1.wasm` again, as compiler commit changed.

Also missing lib/std/math/big/int_test.zig tests.

Also missing `lib/std/math/big/int_test.zig` tests.
@ -1224,0 +1283,4 @@
// => -b * @divTrunc(-a, -b) - b + modCeil(-a, -b) = -a
// => modCeil(-a, -b) = @rem(-a, -b) + b
q.addScalar(q.toConst(),1);
r.add(r.toConst(),y.toConst().abs());
Owner
Copy link

Is this not equivalent to r.sub(r.toConst(), y.toConst()); from the previous case? Handling these two cases differently just makes it look like the math must be wrong.

Is this not equivalent to `r.sub(r.toConst(), y.toConst());` from the previous case? Handling these two cases differently just makes it look like the math must be wrong.
Author
Member
Copy link

Ok, I merged those. Looking at divFloor impl above I can guess, author of this was following same style.

Ok, I merged those. Looking at `divFloor` impl above I can guess, author of this was following same style.
std.math.big: update divCeil add tests
All checks were successful
ci / x86_64-freebsd-release (pull_request) Successful in 48m19s
ci / x86_64-netbsd-release (pull_request) Successful in 52m16s
ci / x86_64-openbsd-release (pull_request) Successful in 51m49s
ci / x86_64-freebsd-debug (pull_request) Successful in 54m32s
ci / x86_64-netbsd-debug (pull_request) Successful in 54m53s
ci / x86_64-windows-release (pull_request) Successful in 1h0m24s
ci / x86_64-openbsd-debug (pull_request) Successful in 1h6m6s
ci / aarch64-macos-release (pull_request) Successful in 1h10m26s
ci / x86_64-windows-debug (pull_request) Successful in 1h13m12s
ci / aarch64-macos-debug (pull_request) Successful in 1h22m18s
ci / s390x-linux-release (pull_request) Successful in 1h33m13s
ci / aarch64-linux-release (pull_request) Successful in 1h43m25s
ci / x86_64-linux-debug (pull_request) Successful in 1h48m32s
ci / powerpc64le-linux-release (pull_request) Successful in 2h27m41s
ci / s390x-linux-debug (pull_request) Successful in 2h34m0s
ci / aarch64-linux-debug (pull_request) Successful in 2h50m40s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 3h38m8s
ci / x86_64-linux-release (pull_request) Successful in 3h57m40s
ci / aarch64-netbsd-debug (pull_request) Has been skipped
ci / aarch64-netbsd-release (pull_request) Has been skipped
ci / powerpc64le-linux-debug (pull_request) Successful in 4h58m50s
ci / aarch64-freebsd-debug (pull_request) Has been skipped
ci / aarch64-freebsd-release (pull_request) Has been skipped
ci / loongarch64-linux-release (pull_request) Successful in 2h37m21s
ci / loongarch64-linux-debug (pull_request) Successful in 3h46m49s
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
e42cb3b236
Author
Member
Copy link

@andrewrk I will merge, when it CI is fully green. You did not reply, but are you ok with stage1.wasm update?

@andrewrk I will merge, when it CI is fully green. You did not reply, but are you ok with `stage1.wasm` update?

Yes, sorry it was not meant to be a merge blocking question.

Yes, sorry it was not meant to be a merge blocking question.

Don't forget to type up release notes for this language change please 🙏

Don't forget to type up release notes for this language change please 🙏
Sign in to join this conversation.
No reviewers
Labels
Clear labels
abi/f32
abi/ilp32
abi/sf
accepted
This proposal is planned.
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
The web application for interactive documentation and generation of its assets.
backend/c
The C backend outputs C source code.
backend/llvm
The LLVM backend outputs an LLVM bitcode module.
backend/self-hosted
The self-hosted backends produce machine code directly.
binutils
Zig's included binary utilities: zig ar, zig dlltool, zig lib, zig ranlib, zig objcopy, and zig rc.
breaking
Implementing this issue could cause existing code to no longer compile or have different behavior.
build system
The Zig build system - zig build, std.Build, the build runner, and package management.
debug info
An issue related to debug information (e.g. DWARF) produced by the Zig compiler.
docs
An issue with documentation, e.g. the language reference or standard library doc comments.
error message
This issue points out an error message that is unhelpful and should be improved.
frontend
Tokenization, parsing, AstGen, ZonGen, Sema, Legalize, and Liveness.
fuzzing
An issue related to Zig's integrated fuzz testing.
incremental
Reuse of internal compiler state for faster compilation.
lib/c
This issue relates to Zig's libc implementation and/or vendored libcs.
lib/compiler-rt
This issue relates to Zig's compiler-rt library.
lib/cxx
This issue relates to Zig's vendored libc++ and/or libc++abi.
lib/std
This issue relates to Zig's standard library.
lib/tsan
This issue relates to Zig's vendored libtsan.
lib/ubsan-rt
This issue relates to Zig's ubsan-rt library.
lib/unwind
This issue relates to Zig's vendored libunwind.
linking
Zig's integrated object file and incremental linker.
miscompilation
The compiler reports success but produces semantically incorrect code.
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
This issue suggests language modifications. If it also has the "accepted" label then it is planned.
release notes
This issue or pull request should be mentioned in the release notes.
testing
This issue is related to testing the compiler, standard library, or other parts of Zig.
zig cc
Zig as a drop-in C-family compiler.
zig fmt
The Zig source code formatter.
zig reduce
The Zig source code reduction tool.
bounty
https://ziglang.org/news/announcing-donor-bounties
bug
Observed behavior contradicts documented or intended behavior.
contributor-friendly
This issue is limited in scope and/or knowledge of project internals.
downstream
An issue with a third-party project that uses this project.
enhancement
Solving this issue will likely involve adding new logic or components to the codebase.
infra
An issue related to project infrastructure, e.g. continuous integration.
optimization
A task to improve performance and/or resource usage.
question
No questions on the issue tracker; use a community space instead.
regression
Something that used to work in a previous version stopped working
upstream
An issue with a third-party project that this project uses.
use case
Describes a real use case that is difficult or impossible, but does not propose a solution.
No labels
abi/f32
abi/ilp32
abi/sf
accepted
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
backend/c
backend/llvm
backend/self-hosted
binutils
breaking
build system
debug info
docs
error message
frontend
fuzzing
incremental
lib/c
lib/compiler-rt
lib/cxx
lib/std
lib/tsan
lib/ubsan-rt
lib/unwind
linking
miscompilation
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
release notes
testing
zig cc
zig fmt
zig reduce
bounty
bug
contributor-friendly
downstream
enhancement
infra
optimization
question
regression
upstream
use case
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ziglang/zig!36043
Reference in a new issue
ziglang/zig
No description provided.
Delete branch "pavelverigo/zig:div-ceil"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?