std.builtin to std.lang #35476
K4/zig:builtin_to_lang into master
contributes towards: https://github.com/ziglang/zig/issues/19690
I found some inconsistencies in files from test/cases/safety/. If desired, I can resolve them in a seperate PR instead of this one.
95ab951bf5
0277abe792
0277abe792
fa8ec1f444
fa8ec1f444
2195a6b527
Thank you for the patch.
I reviewed most of the PR but then I found a change that means I have to request changes.
Unfortunately, since you're not (yet?) a trusted contributor, that means I have to start over reviewing this PR again next round.
Splitting the unrelated changes into a different commit would have prevented this, since I would have caught the issue right away, or doing them in a separate PR would have also prevented this.
@ -1 +1 @@
.{'a','b','c'}
.{'a','b','c'}
these are intentionally excluded from zig fmt because this is testing a parser.
should i write // zig fmt: off?
No, our tests are configured to not check zig fmt here (whereas they do check it for most other Zig source files in the repository), so a disable comment is not needed or wanted. You just need to revert the formatting changes you made (you might need to temporarily disable or override your editor's zig fmt-on-save if you're using it).
How can I revert the changes in test/behavior/zon/slice<xyz>.zon? I cannot do that with my knowledge of vim.
git reset origin/master test/behavior/zon/slice-abc.zon
2195a6b527
d0ee54e6fa
d0ee54e6fa
602a9b960d
@andrewrk wrote in #35476 (comment):
Unfortunately, since you're not (yet?) a trusted contributor, that means I have to start over reviewing this PR again next round.
Can't you just look at the changes I made since then using Codeberg's UI Compare buttons to make sure I didn't do anything of malicious intent?
Edit: Disregard this comment. What I said isn't useful as a way of reviewing this PR plus you have said that you reviewed most of the PR, not all of it.
Test cases are excluded from zig fmt because they sometimes test how errors are affected by differently formatted code.
This is the second time I partially finished reviewing the PR, but will have to start all over again if you submit another change. I don't really want to repeat this process so I'm going to close the PR. It will take me far less time to s/std.builtin/std.lang/ than to review this a third time.
Thank you for trying though. Please pick something more substantial to work on. This kind of thing is both annoying to review and does not bring any value to our users.
No due date set.
No dependencies set.
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?