ziglang/zig
261
6.0k
Fork
You've already forked zig
769

std.zon: fix memory leak #35433

Merged
squeek502 merged 1 commit from chadwain/zig:zon-leak into master 2026年05月29日 00:32:17 +02:00
Contributor
Copy link

Fixes #35269

Fixes #35269
nektro left a comment
Copy link

can you add a reduction as a test? std.testing.allocator has a leak checker

can you add a reduction as a test? `std.testing.allocator` has a leak checker
chadwain force-pushed zon-leak from 7dd79ff977
Some checks failed
ci / x86_64-netbsd-release (pull_request) Successful in 42m57s
ci / x86_64-freebsd-release (pull_request) Successful in 46m27s
ci / x86_64-netbsd-debug (pull_request) Successful in 47m20s
ci / x86_64-openbsd-release (pull_request) Successful in 47m55s
ci / x86_64-windows-release (pull_request) Successful in 47m44s
ci / x86_64-freebsd-debug (pull_request) Successful in 52m44s
ci / x86_64-windows-debug (pull_request) Successful in 53m20s
ci / aarch64-macos-release (pull_request) Successful in 53m48s
ci / x86_64-openbsd-debug (pull_request) Successful in 57m16s
ci / x86_64-linux-debug (pull_request) Successful in 1h5m33s
ci / aarch64-macos-debug (pull_request) Successful in 1h17m29s
ci / aarch64-linux-release (pull_request) Successful in 1h29m46s
ci / s390x-linux-release (pull_request) Successful in 1h33m56s
ci / powerpc64le-linux-release (pull_request) Successful in 2h5m22s
ci / s390x-linux-debug (pull_request) Successful in 2h23m18s
ci / aarch64-linux-debug (pull_request) Successful in 2h31m44s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 2h33m51s
ci / x86_64-linux-release (pull_request) Successful in 2h47m10s
ci / loongarch64-linux-release (pull_request) Successful in 2h14m56s
ci / loongarch64-linux-debug (pull_request) Successful in 3h12m53s
ci / powerpc64le-linux-debug (pull_request) Successful in 4h17m34s
ci / aarch64-freebsd-debug (pull_request) Has been cancelled
ci / aarch64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-netbsd-debug (pull_request) Has been cancelled
ci / aarch64-netbsd-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
to 7686fd20f6
All checks were successful
ci / x86_64-freebsd-release (pull_request) Successful in 43m51s
ci / x86_64-netbsd-debug (pull_request) Successful in 45m10s
ci / x86_64-netbsd-release (pull_request) Successful in 45m32s
ci / x86_64-openbsd-release (pull_request) Successful in 45m22s
ci / x86_64-windows-release (pull_request) Successful in 47m53s
ci / x86_64-freebsd-debug (pull_request) Successful in 50m15s
ci / x86_64-openbsd-debug (pull_request) Successful in 52m46s
ci / aarch64-macos-release (pull_request) Successful in 53m18s
ci / x86_64-windows-debug (pull_request) Successful in 58m9s
ci / x86_64-linux-debug (pull_request) Successful in 1h1m35s
ci / aarch64-macos-debug (pull_request) Successful in 1h16m29s
ci / aarch64-linux-release (pull_request) Successful in 1h27m18s
ci / s390x-linux-release (pull_request) Successful in 1h44m44s
ci / powerpc64le-linux-release (pull_request) Successful in 2h27m52s
ci / s390x-linux-debug (pull_request) Successful in 2h34m5s
ci / loongarch64-linux-release (pull_request) Successful in 2h15m59s
ci / aarch64-linux-debug (pull_request) Successful in 2h41m8s
ci / x86_64-linux-release (pull_request) Successful in 2h47m56s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 2h49m50s
ci / loongarch64-linux-debug (pull_request) Successful in 3h11m43s
ci / powerpc64le-linux-debug (pull_request) Successful in 3h20m45s
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / aarch64-netbsd-debug (pull_request) Successful in 4h27m39s
ci / aarch64-freebsd-debug (pull_request) Successful in 4h21m25s
ci / aarch64-netbsd-release (pull_request) Successful in 3h40m51s
ci / aarch64-freebsd-release (pull_request) Successful in 3h31m28s
2026年05月24日 05:31:14 +02:00 Compare
Author
Contributor
Copy link

added a test case

added a test case
@ -1109,1 +1109,3 @@
constnote:Error.TypeCheckFailure.Note=if(info.fields.len==0)b:{
constnote:?Error.TypeCheckFailure.Note=if(self.diag==null)
null
elseif(info.fields.len==0)b:{

I see that a lot of these failX functions avoid early returns but in this case it seems worth it to just do

fnfailUnexpected(self:@This(),T:type,item_kind:[]constu8,node:Zoir.Node.Index,field:?usize,name:[]constu8,)error{OutOfMemory,ParseZon}{@branchHint(.cold);if(self.diag==null)returnerror.ParseZon;// ...

since all the work done in this function is wasteful when diag is null.

I see that a lot of these `failX` functions avoid early returns but in this case it seems worth it to just do ```zig fn failUnexpected( self: @This(), T: type, item_kind: []const u8, node: Zoir.Node.Index, field: ?usize, name: []const u8, ) error{ OutOfMemory, ParseZon } { @branchHint(.cold); if (self.diag == null) return error.ParseZon; // ... ``` since all the work done in this function is wasteful when `diag` is null.
Author
Contributor
Copy link

I've implemented your suggestion instead

I've implemented your suggestion instead
squeek502 marked this conversation as resolved
chadwain force-pushed zon-leak from 7686fd20f6
All checks were successful
ci / x86_64-freebsd-release (pull_request) Successful in 43m51s
ci / x86_64-netbsd-debug (pull_request) Successful in 45m10s
ci / x86_64-netbsd-release (pull_request) Successful in 45m32s
ci / x86_64-openbsd-release (pull_request) Successful in 45m22s
ci / x86_64-windows-release (pull_request) Successful in 47m53s
ci / x86_64-freebsd-debug (pull_request) Successful in 50m15s
ci / x86_64-openbsd-debug (pull_request) Successful in 52m46s
ci / aarch64-macos-release (pull_request) Successful in 53m18s
ci / x86_64-windows-debug (pull_request) Successful in 58m9s
ci / x86_64-linux-debug (pull_request) Successful in 1h1m35s
ci / aarch64-macos-debug (pull_request) Successful in 1h16m29s
ci / aarch64-linux-release (pull_request) Successful in 1h27m18s
ci / s390x-linux-release (pull_request) Successful in 1h44m44s
ci / powerpc64le-linux-release (pull_request) Successful in 2h27m52s
ci / s390x-linux-debug (pull_request) Successful in 2h34m5s
ci / loongarch64-linux-release (pull_request) Successful in 2h15m59s
ci / aarch64-linux-debug (pull_request) Successful in 2h41m8s
ci / x86_64-linux-release (pull_request) Successful in 2h47m56s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 2h49m50s
ci / loongarch64-linux-debug (pull_request) Successful in 3h11m43s
ci / powerpc64le-linux-debug (pull_request) Successful in 3h20m45s
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / aarch64-netbsd-debug (pull_request) Successful in 4h27m39s
ci / aarch64-freebsd-debug (pull_request) Successful in 4h21m25s
ci / aarch64-netbsd-release (pull_request) Successful in 3h40m51s
ci / aarch64-freebsd-release (pull_request) Successful in 3h31m28s
to e840ad4d5d
Some checks failed
ci / x86_64-netbsd-release (pull_request) Successful in 40m5s
ci / x86_64-freebsd-debug (pull_request) Successful in 43m54s
ci / x86_64-freebsd-release (pull_request) Successful in 44m14s
ci / x86_64-netbsd-debug (pull_request) Successful in 45m16s
ci / x86_64-openbsd-release (pull_request) Successful in 45m49s
ci / x86_64-windows-release (pull_request) Successful in 50m24s
ci / x86_64-openbsd-debug (pull_request) Successful in 50m34s
ci / x86_64-windows-debug (pull_request) Successful in 54m9s
ci / aarch64-macos-release (pull_request) Successful in 55m37s
ci / aarch64-macos-debug (pull_request) Successful in 1h13m23s
ci / aarch64-linux-release (pull_request) Successful in 1h29m50s
ci / powerpc64le-linux-release (pull_request) Successful in 2h11m53s
ci / aarch64-linux-debug (pull_request) Successful in 2h31m51s
ci / powerpc64le-linux-debug (pull_request) Successful in 3h42m20s
ci / s390x-linux-release (pull_request) Successful in 1h40m8s
ci / s390x-linux-debug (pull_request) Successful in 2h18m13s
ci / x86_64-linux-debug (pull_request) Successful in 1h22m40s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 3h54m57s
ci / x86_64-linux-release (pull_request) Successful in 3h54m56s
ci / aarch64-freebsd-debug (pull_request) Has been cancelled
ci / aarch64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-netbsd-debug (pull_request) Has been cancelled
ci / aarch64-netbsd-release (pull_request) Has been cancelled
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
2026年05月28日 14:42:02 +02:00 Compare

Thanks!

Thanks!
Sign in to join this conversation.
No reviewers
Labels
Clear labels
abi/f32
abi/ilp32
abi/sf
accepted
This proposal is planned.
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
The web application for interactive documentation and generation of its assets.
backend/c
The C backend outputs C source code.
backend/llvm
The LLVM backend outputs an LLVM bitcode module.
backend/self-hosted
The self-hosted backends produce machine code directly.
binutils
Zig's included binary utilities: zig ar, zig dlltool, zig lib, zig ranlib, zig objcopy, and zig rc.
breaking
Implementing this issue could cause existing code to no longer compile or have different behavior.
build system
The Zig build system - zig build, std.Build, the build runner, and package management.
debug info
An issue related to debug information (e.g. DWARF) produced by the Zig compiler.
docs
An issue with documentation, e.g. the language reference or standard library doc comments.
error message
This issue points out an error message that is unhelpful and should be improved.
frontend
Tokenization, parsing, AstGen, ZonGen, Sema, Legalize, and Liveness.
fuzzing
An issue related to Zig's integrated fuzz testing.
incremental
Reuse of internal compiler state for faster compilation.
lib/c
This issue relates to Zig's libc implementation and/or vendored libcs.
lib/compiler-rt
This issue relates to Zig's compiler-rt library.
lib/cxx
This issue relates to Zig's vendored libc++ and/or libc++abi.
lib/std
This issue relates to Zig's standard library.
lib/tsan
This issue relates to Zig's vendored libtsan.
lib/ubsan-rt
This issue relates to Zig's ubsan-rt library.
lib/unwind
This issue relates to Zig's vendored libunwind.
linking
Zig's integrated object file and incremental linker.
miscompilation
The compiler reports success but produces semantically incorrect code.
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
This issue suggests language modifications. If it also has the "accepted" label then it is planned.
release notes
This issue or pull request should be mentioned in the release notes.
testing
This issue is related to testing the compiler, standard library, or other parts of Zig.
zig cc
Zig as a drop-in C-family compiler.
zig fmt
The Zig source code formatter.
zig reduce
The Zig source code reduction tool.
bounty
https://ziglang.org/news/announcing-donor-bounties
bug
Observed behavior contradicts documented or intended behavior.
contributor-friendly
This issue is limited in scope and/or knowledge of project internals.
downstream
An issue with a third-party project that uses this project.
enhancement
Solving this issue will likely involve adding new logic or components to the codebase.
infra
An issue related to project infrastructure, e.g. continuous integration.
optimization
A task to improve performance and/or resource usage.
question
No questions on the issue tracker; use a community space instead.
regression
Something that used to work in a previous version stopped working
upstream
An issue with a third-party project that this project uses.
use case
Describes a real use case that is difficult or impossible, but does not propose a solution.
No labels
abi/f32
abi/ilp32
abi/sf
accepted
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
backend/c
backend/llvm
backend/self-hosted
binutils
breaking
build system
debug info
docs
error message
frontend
fuzzing
incremental
lib/c
lib/compiler-rt
lib/cxx
lib/std
lib/tsan
lib/ubsan-rt
lib/unwind
linking
miscompilation
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
release notes
testing
zig cc
zig fmt
zig reduce
bounty
bug
contributor-friendly
downstream
enhancement
infra
optimization
question
regression
upstream
use case
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ziglang/zig!35433
Reference in a new issue
ziglang/zig
No description provided.
Delete branch "chadwain/zig:zon-leak"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?