I based this off the 3DS PR
std.Target: Add wiiu target information #35339
@ -248,6 +248,7 @@ pub fn targetTriple(allocator: Allocator, target: *const std.Target) ![]const u8
.psp,
.tios,
.vita,
.wiiu
You missed the comma here
fixed in 326ec5b1d9
@ -621,0 +623,4 @@
.wiiu=>.{
.semver=.{
.min=.{.major=5,.minor=5,.patch=5},// Latest global release
.max=.{.major=5,.minor=5,.patch=6},// Latest US only release
Where are these versions sourced from?
The OS settings menu, there also is a OS function call (MCP_GetSystemVersion) to get it
@ -2074,1 +2084,4 @@
.nvptx,.nvptx64=>&nvptx.cpu.sm_52,
.powerpc=>switch(os.tag){
.wiiu=>&powerpc.cpu.@"750",
else=>&powerpc.cpu.ppc,
This prong should just do generic(arch).
@ -3391,0 +3409,4 @@
.char=>return8,
.short,.ushort=>return16,
.int,.uint,.float,.long,.ulong=>return32,
.longlong,.ulonglong,.double,.longdouble=>return64,
Can you please verify long double size somehow? This being PowerPC, the long double story is not necessarily straightforward (#30976).
According to $DEVKITPPC/bin/powerpc-eabi-gcc -dM -E - < /dev/null | grep SIZEOF_LONG_DOUBLE: #define __SIZEOF_LONG_DOUBLE__ 8 so long double is 64 bits
@ -6343,6 +6343,7 @@ fn addCommonCCArgs(
.illumos=>tryargv.append("__illumos__"),
// Homebrew targets without LLVM support; use communities's preferred macros.
.@"3ds"=>tryargv.append("-D__3DS__"),
.wiiu=>tryargv.append("-D__WIIU__"),
Is this macro established by any homebrew toolchain or similar?
Also needs to be handled here:
.other,.freestanding,.@"3ds",.psp,.vita=>{},.freestanding,.other,.@"3ds",.vita=>{Just needs a rebase to be mergeable.
2ff39ef9a3
a5c5a9f86f
Damn, never would have thought that adding a new target could result in so many changes.
@ARandomOSDever You should probably rebase the branch a bit more carefully...
yeah, seems like I messed up my rebase
I feel like the simplest way to continue is to recreate the PR
@ARandomOSDever wrote in #35339 (comment):
yeah, seems like I messed up my rebase I feel like the simplest way to continue is to recreate the PR
I mean, not really? I see this a lot in OSS, but you just have to create a clean branch, cherry pick your commits, associate it with this one and force push. But yeah, feel free to do whatever.
I can't reopen this PR (it autoclosed), will create a new one
Edit: I cant create a new PR (it gives me the HTTP 500 error), will try later
Feel free to rebase this PR or create a new one. The 500 error on PRs should be resolved.
b53aa56d24
20b3aa3bcd
@ -622,6 +624,13 @@ pub const Os = struct {
},
},
.wiiu=>.{
Formatting
@ -3419,6 +3432,13 @@ pub fn cTypeBitSize(target: *const Target, c_type: CType) u16 {
.longlong,.ulonglong,.double,.longdouble=>return64,
},
.wiiu=>switch(c_type){
Ditto
No due date set.
No dependencies set.
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?